You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/13 15:48:10 UTC
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request
#4296: Fixes #4037 in 5.x for #4193 in 4.0.1
xiyelife opened a new pull request #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296
Fixes #4037
Changes proposed in this pull request:
- parse the IN operator bracket's index for encrypt rewirte
- fixes encrypt statement IN operator contains space and \n \t \r
- add LP and RP for MySQLVisitor and PostgreSQLVisitor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue
#4296: Fixes #4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296#issuecomment-585855290
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=h1) Report
> Merging [#4296](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/1a179fb21dcc51a7cf58867a0a24ae0bfa00b3d4?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `6.06%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4296 +/- ##
============================================
+ Coverage 59.06% 59.06% +<.01%
Complexity 352 352
============================================
Files 1019 1020 +1
Lines 17510 17537 +27
Branches 3131 3134 +3
============================================
+ Hits 10342 10358 +16
- Misses 6513 6525 +12
+ Partials 655 654 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ngsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9Qb3N0Z3JlU1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...hardingsphere/sql/parser/visitor/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ardingsphere/sql/parser/core/constant/Bracket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2NvbnN0YW50L0JyYWNrZXQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...er/core/extractor/impl/dml/PredicateExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9QcmVkaWNhdGVFeHRyYWN0b3IuamF2YQ==) | `2.25% <0%> (-0.25%)` | `0 <0> (ø)` | |
| [...impl/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVJpZ2h0VmFsdWVUb2tlbkdlbmVyYXRvci5qYXZh) | `90% <100%> (+6.66%)` | `1 <0> (ø)` | :arrow_down: |
| [...rypt/rewrite/condition/EncryptConditionEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL0VuY3J5cHRDb25kaXRpb25FbmdpbmUuamF2YQ==) | `60.41% <100%> (+16.66%)` | `0 <0> (ø)` | :arrow_down: |
| [...ypt/rewrite/condition/impl/EncryptInCondition.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL2ltcGwvRW5jcnlwdEluQ29uZGl0aW9uLmphdmE=) | `88.46% <0%> (+23.07%)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=footer). Last update [1a179fb...5c4b53c](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4296:
Fixes #4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296#issuecomment-585855290
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=h1) Report
> Merging [#4296](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/1a179fb21dcc51a7cf58867a0a24ae0bfa00b3d4?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `8.82%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4296 +/- ##
============================================
+ Coverage 59.06% 59.06% +<.01%
Complexity 352 352
============================================
Files 1019 1020 +1
Lines 17510 17537 +27
Branches 3131 3134 +3
============================================
+ Hits 10342 10358 +16
- Misses 6513 6525 +12
+ Partials 655 654 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ngsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9Qb3N0Z3JlU1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...hardingsphere/sql/parser/visitor/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ardingsphere/sql/parser/core/constant/Bracket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2NvbnN0YW50L0JyYWNrZXQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...er/core/extractor/impl/dml/PredicateExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9QcmVkaWNhdGVFeHRyYWN0b3IuamF2YQ==) | `2.25% <0%> (-0.25%)` | `0 <0> (ø)` | |
| [...impl/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVJpZ2h0VmFsdWVUb2tlbkdlbmVyYXRvci5qYXZh) | `90% <100%> (+6.66%)` | `1 <0> (ø)` | :arrow_down: |
| [...rypt/rewrite/condition/EncryptConditionEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL0VuY3J5cHRDb25kaXRpb25FbmdpbmUuamF2YQ==) | `60.41% <100%> (+16.66%)` | `0 <0> (ø)` | :arrow_down: |
| [...ypt/rewrite/condition/impl/EncryptInCondition.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL2ltcGwvRW5jcnlwdEluQ29uZGl0aW9uLmphdmE=) | `88.46% <0%> (+23.07%)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=footer). Last update [1a179fb...57a7f08](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4296?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4296: Fixes
#4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296#issuecomment-586086914
/run ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4296:
Fixes #4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296#issuecomment-585858947
## Pull Request Test Coverage Report for [Build 9516](https://coveralls.io/builds/28715949)
* **3** of **34** **(8.82%)** changed or added relevant lines in **6** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.02%**) to **62.85%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28715949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L308) | 0 | 5 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28715949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L291) | 0 | 5 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/constant/Bracket.java](https://coveralls.io/builds/28715949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fconstant%2FBracket.java#L27) | 0 | 6 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/PredicateExtractor.java](https://coveralls.io/builds/28715949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2FPredicateExtractor.java#L195) | 0 | 15 | 0.0%
<!-- | **Total:** | **3** | **34** | **8.82%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28715949/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28715949/badge)](https://coveralls.io/builds/28715949) |
| :-- | --: |
| Change from base [Build 846](https://coveralls.io/builds/28711082): | -0.02% |
| Covered Lines: | 11022 |
| Relevant Lines: | 17537 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4296: Fixes #4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296#issuecomment-585858947
## Pull Request Test Coverage Report for [Build 9519](https://coveralls.io/builds/28727279)
* **2** of **33** **(6.06%)** changed or added relevant lines in **6** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.02%**) to **62.85%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28727279/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L308) | 0 | 5 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28727279/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L291) | 0 | 5 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/constant/Bracket.java](https://coveralls.io/builds/28727279/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fconstant%2FBracket.java#L27) | 0 | 6 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/PredicateExtractor.java](https://coveralls.io/builds/28727279/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2FPredicateExtractor.java#L195) | 0 | 15 | 0.0%
<!-- | **Total:** | **2** | **33** | **6.06%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28727279/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28727279/badge)](https://coveralls.io/builds/28727279) |
| :-- | --: |
| Change from base [Build 846](https://coveralls.io/builds/28711082): | -0.02% |
| Covered Lines: | 11022 |
| Relevant Lines: | 17537 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull
request #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
xiyelife commented on a change in pull request #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296#discussion_r379229569
##########
File path: encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java
##########
@@ -121,7 +121,7 @@
predicateSegment.getStopIndex(), compareRightValue.getExpression()))
: Optional.<EncryptCondition>absent();
}
-
+
Review comment:
sorry , I have reseted it .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4296:
Fixes #4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4296: Fixes #4037 in 5.x for #4193 in 4.0.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4296#discussion_r378964570
##########
File path: encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java
##########
@@ -121,7 +121,7 @@
predicateSegment.getStopIndex(), compareRightValue.getExpression()))
: Optional.<EncryptCondition>absent();
}
-
+
Review comment:
Please keep original indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services