You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "haseebmalik18 (via GitHub)" <gi...@apache.org> on 2026/03/12 08:33:30 UTC
[PR] Improve Playwright test patterns in dag-code-tab.spec.ts #63410 [airflow]
haseebmalik18 opened a new pull request, #63416:
URL: https://github.com/apache/airflow/pull/63416
Improve Playwright test patterns in `DagCodePage.ts` to align with Playwright best practices.
- Replace `.waitFor()` with `expect().toBeVisible()` web-first assertions
- Replace manual count assertions with `expect().not.toHaveCount(0)`
- Replace `textContent()` and manual assert with `expect().toHaveText()`
- Replace `getAttribute()` and manual regex with `expect().toHaveAttribute()`
- Replace one-shot `evaluate()` and manual assert with `expect.poll()` retrying assertion
- Move inline `viewLines` locator to class property
closes: #63410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Playwright test patterns in dag-code-tab.spec.ts #63410 [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 merged PR #63416:
URL: https://github.com/apache/airflow/pull/63416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org