[GitHub] [beam] KhaninArtur commented on a change in pull request #17149: [BEAM-13883] [Playground] Increase test coverage for the infrastructure module

[GitBox <gi...@apache.org>]

KhaninArtur commented on a change in pull request #17149:
URL: https://github.com/apache/beam/pull/17149#discussion_r833066215



##########
File path: playground/infrastructure/test_logger.py
##########
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import logging
+
+from logger import setup_logger
+
+
+def test_setup_logger():
+  count_default_handlers = len(logging.getLogger().handlers)
+  setup_logger()
+  assert (len(logging.getLogger().handlers) - count_default_handlers) == 2

Review comment:
       Why do we have 2 logger handlers? Could you please add a comment here why we expect it to equal 2




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org