You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2025/04/28 10:05:42 UTC
[PR] Do not use introspection in migration [airflow]
vincbeck opened a new pull request, #49873:
URL: https://github.com/apache/airflow/pull/49873
Resolves #49570
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not use introspection in DB migration [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #49873:
URL: https://github.com/apache/airflow/pull/49873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not use introspection in DB migration [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #49873:
URL: https://github.com/apache/airflow/pull/49873#discussion_r2069238679
##########
airflow-core/src/airflow/migrations/versions/0028_3_0_0_drop_ab_user_id_foreign_key.py:
##########
@@ -38,54 +37,28 @@
airflow_version = "3.0.0"
-def table_exists(table_name):
- """Check if a table exists in the database."""
- inspector = inspect(op.get_bind())
- return table_name in inspector.get_table_names()
-
-
-def constraint_exists(table_name, constraint_name):
- """Check if a foreign key constraint exists on a table."""
- inspector = inspect(op.get_bind())
- foreign_keys = inspector.get_foreign_keys(table_name)
- return any(fk["name"] == constraint_name for fk in foreign_keys)
-
-
-def index_exists(table_name, index_name):
- """Check if an index exists on a table."""
- inspector = inspect(op.get_bind())
- indexes = inspector.get_indexes(table_name)
- return any(idx["name"] == index_name for idx in indexes)
-
-
def upgrade():
"""Apply Drop ab_user.id foreign key."""
- if constraint_exists("dag_run_note", "dag_run_note_user_fkey"):
- with op.batch_alter_table("dag_run_note", schema=None) as batch_op:
- batch_op.drop_constraint("dag_run_note_user_fkey", type_="foreignkey")
-
- if constraint_exists("task_instance_note", "task_instance_note_user_fkey"):
- with op.batch_alter_table("task_instance_note", schema=None) as batch_op:
- batch_op.drop_constraint("task_instance_note_user_fkey", type_="foreignkey")
+ with op.batch_alter_table("dag_run_note", schema=None) as batch_op:
Review Comment:
Yeah, I have no context of why it was added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not use introspection in DB migration [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #49873:
URL: https://github.com/apache/airflow/pull/49873#issuecomment-2843276419
> We should wait for @ephraimbuddy to review it too when he is back next week I think
Definitely, there is no rush 👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not use introspection in DB migration [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck closed pull request #49873: Do not use introspection in DB migration
URL: https://github.com/apache/airflow/pull/49873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not use introspection in DB migration [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #49873:
URL: https://github.com/apache/airflow/pull/49873#discussion_r2068330482
##########
airflow-core/src/airflow/migrations/versions/0028_3_0_0_drop_ab_user_id_foreign_key.py:
##########
@@ -38,54 +37,28 @@
airflow_version = "3.0.0"
-def table_exists(table_name):
- """Check if a table exists in the database."""
- inspector = inspect(op.get_bind())
- return table_name in inspector.get_table_names()
-
-
-def constraint_exists(table_name, constraint_name):
- """Check if a foreign key constraint exists on a table."""
- inspector = inspect(op.get_bind())
- foreign_keys = inspector.get_foreign_keys(table_name)
- return any(fk["name"] == constraint_name for fk in foreign_keys)
-
-
-def index_exists(table_name, index_name):
- """Check if an index exists on a table."""
- inspector = inspect(op.get_bind())
- indexes = inspector.get_indexes(table_name)
- return any(idx["name"] == index_name for idx in indexes)
-
-
def upgrade():
"""Apply Drop ab_user.id foreign key."""
- if constraint_exists("dag_run_note", "dag_run_note_user_fkey"):
- with op.batch_alter_table("dag_run_note", schema=None) as batch_op:
- batch_op.drop_constraint("dag_run_note_user_fkey", type_="foreignkey")
-
- if constraint_exists("task_instance_note", "task_instance_note_user_fkey"):
- with op.batch_alter_table("task_instance_note", schema=None) as batch_op:
- batch_op.drop_constraint("task_instance_note_user_fkey", type_="foreignkey")
+ with op.batch_alter_table("dag_run_note", schema=None) as batch_op:
Review Comment:
In theory you can also use `if context.is_offline_mode():`
Some example: https://github.com/search?q=repo%3Aapache%2Fairflow%20context.is_offline_mode()%3A&type=code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not use introspection in DB migration [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #49873:
URL: https://github.com/apache/airflow/pull/49873#discussion_r2069138991
##########
airflow-core/src/airflow/migrations/versions/0028_3_0_0_drop_ab_user_id_foreign_key.py:
##########
@@ -38,54 +37,28 @@
airflow_version = "3.0.0"
-def table_exists(table_name):
- """Check if a table exists in the database."""
- inspector = inspect(op.get_bind())
- return table_name in inspector.get_table_names()
-
-
-def constraint_exists(table_name, constraint_name):
- """Check if a foreign key constraint exists on a table."""
- inspector = inspect(op.get_bind())
- foreign_keys = inspector.get_foreign_keys(table_name)
- return any(fk["name"] == constraint_name for fk in foreign_keys)
-
-
-def index_exists(table_name, index_name):
- """Check if an index exists on a table."""
- inspector = inspect(op.get_bind())
- indexes = inspector.get_indexes(table_name)
- return any(idx["name"] == index_name for idx in indexes)
-
-
def upgrade():
"""Apply Drop ab_user.id foreign key."""
- if constraint_exists("dag_run_note", "dag_run_note_user_fkey"):
- with op.batch_alter_table("dag_run_note", schema=None) as batch_op:
- batch_op.drop_constraint("dag_run_note_user_fkey", type_="foreignkey")
-
- if constraint_exists("task_instance_note", "task_instance_note_user_fkey"):
- with op.batch_alter_table("task_instance_note", schema=None) as batch_op:
- batch_op.drop_constraint("task_instance_note_user_fkey", type_="foreignkey")
+ with op.batch_alter_table("dag_run_note", schema=None) as batch_op:
Review Comment:
But we actually do not need to check the existence of tables/indexes, so it is even better to remove the ifs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org