You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/12/03 14:44:00 UTC

Review Request 28645: Delete old project name (ivory) from code and xmls

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28645/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-930
    https://issues.apache.org/jira/browse/FALCON-930


Repository: falcon-git


Description
-------

'ivory' deleted from paths in xmls
Bundle don't expect 'uri:ivory' in xmls
Merlin.properties should contain hostname property instead of ivory_hostname
hadoopGetCommand deleted as unused


Diffs
-----

  falcon-regression/README.md abfa689 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java d5dec6e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/JmsMessageConsumer.java 1ded57c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 7ead733 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 0c12410 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java f751119 
  falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/cluster-0.1.xml 3c30e92 
  falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template1.xml 2a1d9f7 
  falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template2.xml 89ad45e 
  falcon-regression/merlin/src/test/resources/ELbundle/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/ELbundle/feed-template1.xml 2114bb9 
  falcon-regression/merlin/src/test/resources/ELbundle/feed-template2.xml 08c5f5d 
  falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template1.xml 2da8e1c 
  falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template2.xml 1ddac37 
  falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template1.xml 2da8e1c 
  falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template2.xml 1ddac37 
  falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml d1e262a 
  falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/cluster-0.1.xml e36f18f 
  falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template1.xml 5350d0a 
  falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template2.xml d9e4e32 
  falcon-regression/merlin/src/test/resources/ReplicationResources/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/cluster-0.1.xml e36f18f 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-hdfsoutputdir.xml d14a280 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-inpath.xml 326830b 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-interpath.xml d3c0326 
  falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/cluster-0.1.xml e36f18f 
  falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template1.xml e317d41 
  falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template2.xml f2df5e6 
  falcon-regression/merlin/src/test/resources/hcat/cluster-0.1.xml 9951490 
  falcon-regression/merlin/src/test/resources/hcat_2/cluster-0.1.xml 31ea831 
  falcon-regression/merlin/src/test/resources/updateBundle/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/updateBundle/feed-template1.xml 4558cac 
  falcon-regression/merlin/src/test/resources/updateBundle/feed-template2.xml b6c175e 

Diff: https://reviews.apache.org/r/28645/diff/


Testing
-------

tested reading 'hostname' property


Thanks,

Ruslan Ostafiychuk


Re: Review Request 28645: Delete old project name (ivory) from code and xmls

Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28645/#review63792
-----------------------------------------------------------

Ship it!


Ship It!

- Raghav Gautam


On Dec. 3, 2014, 5:44 a.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28645/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 5:44 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-930
>     https://issues.apache.org/jira/browse/FALCON-930
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> 'ivory' deleted from paths in xmls
> Bundle don't expect 'uri:ivory' in xmls
> Merlin.properties should contain hostname property instead of ivory_hostname
> hadoopGetCommand deleted as unused
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md abfa689 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java d5dec6e 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/JmsMessageConsumer.java 1ded57c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 7ead733 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 0c12410 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java f751119 
>   falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/cluster-0.1.xml 3c30e92 
>   falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template1.xml 2a1d9f7 
>   falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template2.xml 89ad45e 
>   falcon-regression/merlin/src/test/resources/ELbundle/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/ELbundle/feed-template1.xml 2114bb9 
>   falcon-regression/merlin/src/test/resources/ELbundle/feed-template2.xml 08c5f5d 
>   falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template1.xml 2da8e1c 
>   falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template2.xml 1ddac37 
>   falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template1.xml 2da8e1c 
>   falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template2.xml 1ddac37 
>   falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml d1e262a 
>   falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/cluster-0.1.xml e36f18f 
>   falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template1.xml 5350d0a 
>   falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template2.xml d9e4e32 
>   falcon-regression/merlin/src/test/resources/ReplicationResources/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/cluster-0.1.xml e36f18f 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-hdfsoutputdir.xml d14a280 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-inpath.xml 326830b 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-interpath.xml d3c0326 
>   falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/cluster-0.1.xml e36f18f 
>   falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template1.xml e317d41 
>   falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template2.xml f2df5e6 
>   falcon-regression/merlin/src/test/resources/hcat/cluster-0.1.xml 9951490 
>   falcon-regression/merlin/src/test/resources/hcat_2/cluster-0.1.xml 31ea831 
>   falcon-regression/merlin/src/test/resources/updateBundle/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/updateBundle/feed-template1.xml 4558cac 
>   falcon-regression/merlin/src/test/resources/updateBundle/feed-template2.xml b6c175e 
> 
> Diff: https://reviews.apache.org/r/28645/diff/
> 
> 
> Testing
> -------
> 
> tested reading 'hostname' property
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>


Re: Review Request 28645: Delete old project name (ivory) from code and xmls

Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28645/#review63677
-----------------------------------------------------------

Ship it!


Ship It!

- Paul Isaychuk


On Dec. 3, 2014, 1:44 p.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28645/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 1:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-930
>     https://issues.apache.org/jira/browse/FALCON-930
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> 'ivory' deleted from paths in xmls
> Bundle don't expect 'uri:ivory' in xmls
> Merlin.properties should contain hostname property instead of ivory_hostname
> hadoopGetCommand deleted as unused
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md abfa689 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java d5dec6e 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/JmsMessageConsumer.java 1ded57c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 7ead733 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 0c12410 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java f751119 
>   falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/cluster-0.1.xml 3c30e92 
>   falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template1.xml 2a1d9f7 
>   falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template2.xml 89ad45e 
>   falcon-regression/merlin/src/test/resources/ELbundle/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/ELbundle/feed-template1.xml 2114bb9 
>   falcon-regression/merlin/src/test/resources/ELbundle/feed-template2.xml 08c5f5d 
>   falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template1.xml 2da8e1c 
>   falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template2.xml 1ddac37 
>   falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template1.xml 2da8e1c 
>   falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template2.xml 1ddac37 
>   falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml d1e262a 
>   falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/cluster-0.1.xml e36f18f 
>   falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template1.xml 5350d0a 
>   falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template2.xml d9e4e32 
>   falcon-regression/merlin/src/test/resources/ReplicationResources/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/cluster-0.1.xml e36f18f 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-hdfsoutputdir.xml d14a280 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-inpath.xml 326830b 
>   falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-interpath.xml d3c0326 
>   falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/cluster-0.1.xml e36f18f 
>   falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template1.xml e317d41 
>   falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template2.xml f2df5e6 
>   falcon-regression/merlin/src/test/resources/hcat/cluster-0.1.xml 9951490 
>   falcon-regression/merlin/src/test/resources/hcat_2/cluster-0.1.xml 31ea831 
>   falcon-regression/merlin/src/test/resources/updateBundle/cluster-0.1.xml 64028fe 
>   falcon-regression/merlin/src/test/resources/updateBundle/feed-template1.xml 4558cac 
>   falcon-regression/merlin/src/test/resources/updateBundle/feed-template2.xml b6c175e 
> 
> Diff: https://reviews.apache.org/r/28645/diff/
> 
> 
> Testing
> -------
> 
> tested reading 'hostname' property
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>


Re: Review Request 28645: Delete old project name (ivory) from code and xmls

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28645/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 1:44 p.m.)


Review request for Falcon.


Bugs: FALCON-930
    https://issues.apache.org/jira/browse/FALCON-930


Repository: falcon-git


Description
-------

'ivory' deleted from paths in xmls
Bundle don't expect 'uri:ivory' in xmls
Merlin.properties should contain hostname property instead of ivory_hostname
hadoopGetCommand deleted as unused


Diffs
-----

  falcon-regression/README.md abfa689 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java d5dec6e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/JmsMessageConsumer.java 1ded57c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 7ead733 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 0c12410 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java f751119 
  falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/cluster-0.1.xml 3c30e92 
  falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template1.xml 2a1d9f7 
  falcon-regression/merlin/src/test/resources/AvailabilityBundle/valid/bundle1/feed-template2.xml 89ad45e 
  falcon-regression/merlin/src/test/resources/ELbundle/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/ELbundle/feed-template1.xml 2114bb9 
  falcon-regression/merlin/src/test/resources/ELbundle/feed-template2.xml 08c5f5d 
  falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template1.xml 2da8e1c 
  falcon-regression/merlin/src/test/resources/EmptyInputTagProcess/feed-template2.xml 1ddac37 
  falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template1.xml 2da8e1c 
  falcon-regression/merlin/src/test/resources/EmptyOutputTagProcess/feed-template2.xml 1ddac37 
  falcon-regression/merlin/src/test/resources/FeedReplicaltionBundles/cluster-0.1.xml d1e262a 
  falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/cluster-0.1.xml e36f18f 
  falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template1.xml 5350d0a 
  falcon-regression/merlin/src/test/resources/LateDataBundles/valid1/bundle1/feed-template2.xml d9e4e32 
  falcon-regression/merlin/src/test/resources/ReplicationResources/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/cluster-0.1.xml e36f18f 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-hdfsoutputdir.xml d14a280 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-inpath.xml 326830b 
  falcon-regression/merlin/src/test/resources/RetentionBundles/valid/bundle1/feed-interpath.xml d3c0326 
  falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/cluster-0.1.xml e36f18f 
  falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template1.xml e317d41 
  falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/feed-template2.xml f2df5e6 
  falcon-regression/merlin/src/test/resources/hcat/cluster-0.1.xml 9951490 
  falcon-regression/merlin/src/test/resources/hcat_2/cluster-0.1.xml 31ea831 
  falcon-regression/merlin/src/test/resources/updateBundle/cluster-0.1.xml 64028fe 
  falcon-regression/merlin/src/test/resources/updateBundle/feed-template1.xml 4558cac 
  falcon-regression/merlin/src/test/resources/updateBundle/feed-template2.xml b6c175e 

Diff: https://reviews.apache.org/r/28645/diff/


Testing
-------

tested reading 'hostname' property


Thanks,

Ruslan Ostafiychuk