You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by benoyantony <gi...@git.apache.org> on 2017/04/28 22:13:33 UTC
[GitHub] zeppelin pull request #2301: [ZEPPELIN-1625] Override Interpreter settings a...
GitHub user benoyantony opened a pull request:
https://github.com/apache/zeppelin/pull/2301
[ZEPPELIN-1625] Override Interpreter settings at User level
### What is this PR for?
When multiple users share a zeppelin instance, it is sometimes desirable to use the same interpreter with different settings.
It should be possible an administrator to setup some of the Interpreter settings as overridable by setting a place holder and a default value
It should be possible for a user to specify the actual values via properties.
### What type of PR is it?
Feature
### Todos
Override interpreter setting at notebook level
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1625
### How should this be tested?
Unit tests are added.
Please see screen shots for manual testing
### Screenshots
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? Yes , added
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benoyantony/zeppelin user_properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2301
----
commit 6972b7cf094ef07a2a1e295169966656f638f361
Author: Benoy Antony <be...@apache.org>
Date: 2017-04-28T22:08:45Z
ZEPPELIN-1625 Override Interpreter settings at User level
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2301: [ZEPPELIN-1625] Override Interpreter settings at User ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2301
@benoyantony Did you check ZEPPELIN-1338 ? Your approach seems some kind of workaround to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2301: [ZEPPELIN-1625] Override Interpreter settings a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2301
---
[GitHub] zeppelin issue #2301: [ZEPPELIN-1625] Override Interpreter settings at User ...
Posted by benoyantony <gi...@git.apache.org>.
Github user benoyantony commented on the issue:
https://github.com/apache/zeppelin/pull/2301
@zjffdu , Thanks for pointing me to ZEPPELIN-1338. I did not know about it. I believe, the intent is same. I agree that the approach is different. We wanted to shield the user from interpreter settings.
The approach in this change is to specify a property name and default value in the interpreter setting. Users can set a value for the property. When the interpreter is created, then the user's property value is used as the interpreter setting.
User's properties are persisted.
One advantage of this approach is to use the same property across multiple interpreter settings.
We have been using this feature at our company for last 3 months and its been effective.
I'll review ZEPPELIN-1338 carefully to understand the approach mentioned in that. Thanks again for letting me know of the related effort. Its good to know that its a feature needed by many.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2301: [ZEPPELIN-1625] Override Interpreter settings at User ...
Posted by esmevane <gi...@git.apache.org>.
Github user esmevane commented on the issue:
https://github.com/apache/zeppelin/pull/2301
Hello there, @benoyantony - could you update me on where you and your team wound up with this? I'm working on something which sounds pretty similar and I'd love to know what you all decided.
---
[GitHub] zeppelin issue #2301: [ZEPPELIN-1625] Override Interpreter settings at User ...
Posted by benoyantony <gi...@git.apache.org>.
Github user benoyantony commented on the issue:
https://github.com/apache/zeppelin/pull/2301
@Leemoonsoo , Could you please review this feature ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---