[GitHub] [incubator-nuttx] antmerlino edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.

[GitBox <gi...@apache.org>]

antmerlino edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824446646


   > 
   > 
   > This is required to support dhcp bootp unicast.
   > This looks like this https://community.arubanetworks.com/browse/articles/blogviewer?blogkey=f5df0149-baf4-485a-9c1b-5e136b1a7ad2
   
   @btashton 
   
   There are some useful bits in here:
   https://networkengineering.stackexchange.com/questions/16947/is-a-dhcp-offer-packet-a-broadcast-or-unicast
   
   So I understand why it's needed now, but I still don't think the way it's implemented is acceptable. 
   
   Two things mentioned in the link above that might be helpful:
   
   1. Some hosts simply don't support receiving unicast before an IP is assigned.
   2. On the hosts that do, I see notes about checking the L2 address
   
   Another thought after reading that is that we only enable this logic when there is not an IP address assigned. 
   
   I propose 2 things:
     1) Add a Kconfig option for allowing unicast before IP address is set that enables this behavior - this way users have to opt-in for this.
     2) Only allow UDP unicaset not destined for us through when we haven't assigned an IP address yet.
     
     Let me know what you think
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org