You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/12/15 20:57:26 UTC
[Toolchain-CR] Add autotools packages as build prerequisites
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5524
Change subject: Add autotools packages as build prerequisites
......................................................................
Add autotools packages as build prerequisites
* Add autoconf, automake and libtool.
* Versions are those installed in Ubuntu 14.04.
Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
---
M init.sh
A source/autoconf/build.sh
A source/automake/build.sh
A source/libtool/build.sh
4 files changed, 132 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/24/5524/1
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Toolchain-CR] Add autotools packages as build prerequisites
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5524
to look at the new patch set (#2).
Change subject: Add autotools packages as build prerequisites
......................................................................
Add autotools packages as build prerequisites
* Add autoconf, automake and libtool.
* Versions are those installed in Ubuntu 14.04.
Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
---
M init.sh
A source/autoconf/build.sh
A source/automake/build.sh
A source/libtool/build.sh
4 files changed, 133 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/24/5524/2
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] Add autotools packages as build prerequisites
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Add autotools packages as build prerequisites
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] Add autotools packages as build prerequisites
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5524
to look at the new patch set (#3).
Change subject: Add autotools packages as build prerequisites
......................................................................
Add autotools packages as build prerequisites
* Add autoconf, automake and libtool.
* Versions are those installed in Ubuntu 14.04.
* Autotools are only enabled for those packages that require them. See
enable_toolchain_autotools().
Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
---
M functions.sh
M init.sh
A source/autoconf/build.sh
A source/automake/build.sh
A source/libtool/build.sh
5 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/24/5524/3
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] Add autotools packages as build prerequisites
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add autotools packages as build prerequisites
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] Add autotools packages as build prerequisites
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add autotools packages as build prerequisites
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] Add autotools packages as build prerequisites
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Add autotools packages as build prerequisites
......................................................................
Patch Set 3:
Changed to only enable autotools for packages that require them, rather than everywhere. This passed a full toolchain build on all platforms.
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] Add autotools packages as build prerequisites
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.
Change subject: Add autotools packages as build prerequisites
......................................................................
Add autotools packages as build prerequisites
* Add autoconf, automake and libtool.
* Versions are those installed in Ubuntu 14.04.
* Autotools are only enabled for those packages that require them. See
enable_toolchain_autotools().
Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
---
M functions.sh
M init.sh
A source/autoconf/build.sh
A source/automake/build.sh
A source/libtool/build.sh
5 files changed, 141 insertions(+), 0 deletions(-)
Approvals:
Henry Robinson: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43218d1bdd4d660f1e50774a90de1733b4be10ee
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>