[jira] [Commented] (PIO-90) Improve /batch/events.json endpoint performance

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIO-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046554#comment-16046554 ] 

ASF GitHub Bot commented on PIO-90:
-----------------------------------

Github user marevol commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/386
  
    LGTM


> Improve /batch/events.json endpoint performance
> -----------------------------------------------
>
>                 Key: PIO-90
>                 URL: https://issues.apache.org/jira/browse/PIO-90
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Naoki Takezoe
>            Assignee: Naoki Takezoe
>
> It's possible to improve /batch/events.json endpoint of the event server performance by using batch inserting in storage implementations. For example, Elasticsearch has bulk API and also JDBC has batch updating.
> I propose adding LEvent.futureInsertBatch() that takes Seq[Event] and modify /batch/events.json endpoint to use it. The default implementation is calling existing futureInsert() per event, and we can override it in the storage implementation to use storage specific batch inserting API.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)