You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "MonsterChenzhuo (via GitHub)" <gi...@apache.org> on 2023/04/22 11:50:49 UTC
[GitHub] [incubator-seatunnel] MonsterChenzhuo opened a new pull request, #4645: [Hotfix][Connector-e2e][File-local] Complete the e2e test case env co…
MonsterChenzhuo opened a new pull request, #4645:
URL: https://github.com/apache/incubator-seatunnel/pull/4645
…nfiguration
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] MonsterChenzhuo commented on a diff in pull request #4645: [Hotfix][Connector-e2e][File-local] Complete the e2e test case env co…
Posted by "MonsterChenzhuo (via GitHub)" <gi...@apache.org>.
MonsterChenzhuo commented on code in PR #4645:
URL: https://github.com/apache/incubator-seatunnel/pull/4645#discussion_r1174428537
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_to_assert.conf:
##########
@@ -51,22 +66,7 @@ source {
c_date = date
c_decimal = "decimal(38, 18)"
c_timestamp = timestamp
- c_row = {
Review Comment:
@TyrantLucifer It's not deletion, but not using the hecon plug-in to format the file content at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4645: [Hotfix][Connector-e2e][File-local] Complete the e2e test case env co…
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #4645:
URL: https://github.com/apache/incubator-seatunnel/pull/4645#discussion_r1174403262
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_projection_to_assert.conf:
##########
@@ -42,22 +67,7 @@ source {
c_date = date
c_decimal = "decimal(38, 18)"
c_timestamp = timestamp
- c_row = {
Review Comment:
Why delete it?
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_to_assert.conf:
##########
@@ -51,22 +66,7 @@ source {
c_date = date
c_decimal = "decimal(38, 18)"
c_timestamp = timestamp
- c_row = {
Review Comment:
Why delete it?
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_projection_to_assert.conf:
##########
@@ -18,16 +18,41 @@
###### This config file is a demonstration of streaming processing in seatunnel config
######
+env {
Review Comment:
It's duplicate with #4615 https://github.com/apache/incubator-seatunnel/pull/4615/files#diff-ee22b91619cbf4eea14ae402900bf2bb469e4ad4a2a6d1387af1c3db93d5d7fcR21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4645: [Hotfix][Connector-e2e][File-local] Complete the e2e test case env co…
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #4645: [Hotfix][Connector-e2e][File-local] Complete the e2e test case env co…
URL: https://github.com/apache/incubator-seatunnel/pull/4645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org