You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/11/03 03:09:11 UTC
Re: Review Request 38342: Add JSON::protobuf for
google::protobuf::RepeatedPtrField (stout part)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review104848
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Oct. 20, 2015, 2:39 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 2:39 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
>
>
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField<T>` by introducing overloaded functions.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp f0e7870
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9
>
> Diff: https://reviews.apache.org/r/38342/diff/
>
>
> Testing
> -------
>
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
>
>
> Thanks,
>
> Klaus Ma
>
>