[GitHub] [maven-surefire] Tibor17 commented on issue #248: SUREFIRE-1695 Support multiple inheritance of @Categories

[GitBox <gi...@apache.org>]

Tibor17 commented on issue #248: SUREFIRE-1695 Support multiple inheritance of @Categories
URL: https://github.com/apache/maven-surefire/pull/248#issuecomment-569525999
 
 
   @YiannisDermitzakis 
   It looks good but still it is incomplete. Typically the unit tests must be included in `JUnit4SuiteTest`. The problem here is that `GroupMatcherCategoryFilterPreJUnit412Test` has to have older `junit` library in the test classpath and the test `GroupMatcherCategoryFilterTest` requires the version `4.12`. It can be done but you have to modify the executions of the plugin https://github.com/apache/maven-surefire/blob/84fc3518b999f3ffba522840a9a6551fe00d7ee5/surefire-providers/common-junit48/pom.xml#L76 so that the pase `default-test` of the first execution with the configuration as you can see in the POM. The second execution should have another phase id name with new config, new test suite class pointing to the `GroupMatcherCategoryFilterTest` and `junit:4.12` referenced by `additionalClasspathElements`. Here is an example to copy external artifact to a separate folder under `/target`, see `${project.build.directory}/endorsed-test` and https://github.com/apache/maven-surefire/blob/84fc3518b999f3ffba522840a9a6551fe00d7ee5/surefire-providers/surefire-junit47/pom.xml#L125

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services