You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/25 23:34:36 UTC
[GitHub] [hudi] zhedoubushishi opened a new pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
zhedoubushishi opened a new pull request #4915:
URL: https://github.com/apache/hudi/pull/4915
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#issuecomment-1051367237
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6332",
"triggerID" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 402156b00dfb5d49593f80df9d18656e08fd3dcb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6332)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#issuecomment-1055983261
@zhedoubushishi : Fix the title once the PR is ready to be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#issuecomment-1051367237
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6332",
"triggerID" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 402156b00dfb5d49593f80df9d18656e08fd3dcb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6332)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#issuecomment-1051405803
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6332",
"triggerID" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 402156b00dfb5d49593f80df9d18656e08fd3dcb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6332)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhedoubushishi commented on a change in pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
zhedoubushishi commented on a change in pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#discussion_r840113380
##########
File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSqlConf.scala
##########
@@ -85,6 +87,15 @@ class TestSqlConf extends TestHoodieSqlBase with BeforeAndAfter {
s"$tablePath/" + HoodieTableMetaClient.METAFOLDER_NAME,
HoodieTableConfig.PAYLOAD_CLASS_NAME.defaultValue).getTableType)
+ // Manually pass incremental configs to global configs to make sure Hudi query is able to load the
+ // global configs
+ DFSPropertiesConfiguration.addToGlobalProps(QUERY_TYPE.key, QUERY_TYPE_INCREMENTAL_OPT_VAL)
Review comment:
> @zhedoubushishi : whats the scope of these configs. Is it the full spark-sql or spark-shell session ? also, users have to remember to remove them if for 2nd query they don't need these configs right?
It would be the cluster level which means each query would have this option by default.
users have to remember to remove them if for 2nd query they don't need these configs right? - yes you are right.
Actually here I used a bad example, practically we shouldn't set `QUERY_TYPE` inside the external config file.
This change is aim to fix the situation when customer enabled metadata table in the external file. Then for each query, they should query with metadata table enabled by default.
But it's kind of difficult to test the above scenario, so I came up with this bad example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan edited a comment on pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
nsivabalan edited a comment on pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#issuecomment-1055983261
@zhedoubushishi : Fix the title/link jira once the PR is ready to be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#discussion_r839010055
##########
File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSqlConf.scala
##########
@@ -85,6 +87,15 @@ class TestSqlConf extends TestHoodieSqlBase with BeforeAndAfter {
s"$tablePath/" + HoodieTableMetaClient.METAFOLDER_NAME,
HoodieTableConfig.PAYLOAD_CLASS_NAME.defaultValue).getTableType)
+ // Manually pass incremental configs to global configs to make sure Hudi query is able to load the
+ // global configs
+ DFSPropertiesConfiguration.addToGlobalProps(QUERY_TYPE.key, QUERY_TYPE_INCREMENTAL_OPT_VAL)
Review comment:
@zhedoubushishi : whats the scope of these configs. Is it the full spark-sql or spark-shell session ? also, users have to remember to remove them if for 2nd query they don't need these configs right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#issuecomment-1051365831
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 402156b00dfb5d49593f80df9d18656e08fd3dcb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4915: [WIP] Allow loading external configs while querying Hudi tables with Spark
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4915:
URL: https://github.com/apache/hudi/pull/4915#issuecomment-1051365831
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "402156b00dfb5d49593f80df9d18656e08fd3dcb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 402156b00dfb5d49593f80df9d18656e08fd3dcb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org