You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Roman Donchenko <DX...@yandex.ru> on 2009/07/30 20:16:45 UTC
[PATCH] Dehardcode the Python bindings version in the installer
generator
Greetings,
As you might have guessed, the previous patch was to enable this one. 8=]
[[[
Make the SWIG/Python bindings installer generator use the correct version
number automatically.
packages/python-windows/setup.py: Replace the hardcoded version number
with svn.core.SVN_VER_NUMBER.
packages/python-windows/README.txt: Remove the step telling the user to
correct said version number.
]]]
Cheers,
Roman.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377130
Re: [PATCH] Dehardcode the Python bindings version in the installer
generator
Posted by Roman Donchenko <DX...@yandex.ru>.
D.J. Heap <dj...@gmail.com> писал в своём письме Fri, 31 Jul 2009
18:49:32 +0400:
> On Fri, Jul 31, 2009 at 8:32 AM, Roman Donchenko<DX...@yandex.ru>
> wrote:
> [snip[
>>
>> Sure I did. Committed in r38511.
>>
>
>
> This builds the installer, it doesn't install the bindings and no step
> in our build process installs the bindings that I know of, so how does
> this work? Am I missing something or is it just pulling in the last
> installed bindings version?
When we run the script, the bindings we are packaging should be in the
current directory, and thus can be imported used from within the script.
Since the version of the bindings is equal to the version of Subversion
they are built against (which is recorded in SVN_VER*), we can just
substitute the latter.
Roman.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377444
Re: [PATCH] Dehardcode the Python bindings version in the installer
generator
Posted by "D.J. Heap" <dj...@gmail.com>.
On Fri, Jul 31, 2009 at 9:52 AM, Julian Foad<ju...@btopenworld.com> wrote:
[snip]
>
> That puzzled me too. I believe the answer is that Python's "from X
> import Y" first looks in a subdirectory named X in the current
> directory, which in this case it finds. :-)
Ah, thanks to you and Roman for the explanation -- that is very handy to know.
DJ
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377494
Re: [PATCH] Dehardcode the Python bindings version in the installer
generator
Posted by Julian Foad <ju...@btopenworld.com>.
On Fri, 2009-07-31 at 08:49 -0600, D.J. Heap wrote:
> On Fri, Jul 31, 2009 at 8:32 AM, Roman Donchenko<DX...@yandex.ru> wrote:
> [snip[
> >
> > Sure I did. Committed in r38511.
> >
>
>
> This builds the installer, it doesn't install the bindings and no step
> in our build process installs the bindings that I know of, so how does
> this work? Am I missing something or is it just pulling in the last
> installed bindings version?
That puzzled me too. I believe the answer is that Python's "from X
import Y" first looks in a subdirectory named X in the current
directory, which in this case it finds. :-)
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377465
Re: [PATCH] Dehardcode the Python bindings version in the installer
generator
Posted by "D.J. Heap" <dj...@gmail.com>.
On Fri, Jul 31, 2009 at 8:32 AM, Roman Donchenko<DX...@yandex.ru> wrote:
[snip[
>
> Sure I did. Committed in r38511.
>
This builds the installer, it doesn't install the bindings and no step
in our build process installs the bindings that I know of, so how does
this work? Am I missing something or is it just pulling in the last
installed bindings version?
DJ
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377426
Re: [PATCH] Dehardcode the Python bindings version in the installer
generator
Posted by Roman Donchenko <DX...@yandex.ru>.
David James <ja...@gmail.com> писал в своём письме Fri, 31 Jul 2009
03:04:15 +0400:
> On Thu, Jul 30, 2009 at 1:16 PM, Roman Donchenko<DX...@yandex.ru>
> wrote:
>> Greetings,
>>
>> As you might have guessed, the previous patch was to enable this one.
>> 8=]
>>
>> [[[
>> Make the SWIG/Python bindings installer generator use the correct
>> version
>> number automatically.
>>
>> packages/python-windows/setup.py: Replace the hardcoded version number
>> with svn.core.SVN_VER_NUMBER.
>>
>> packages/python-windows/README.txt: Remove the step telling the user to
>> correct said version number.
>> ]]]
>
> Hm, this sounds good. +1, as long as you've tested it on Windows
>
> Cheers,
>
> David
Sure I did. Committed in r38511.
Roman.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377416
Re: [PATCH] Dehardcode the Python bindings version in the installer
generator
Posted by David James <ja...@gmail.com>.
On Thu, Jul 30, 2009 at 1:16 PM, Roman Donchenko<DX...@yandex.ru> wrote:
> Greetings,
>
> As you might have guessed, the previous patch was to enable this one. 8=]
>
> [[[
> Make the SWIG/Python bindings installer generator use the correct version
> number automatically.
>
> packages/python-windows/setup.py: Replace the hardcoded version number
> with svn.core.SVN_VER_NUMBER.
>
> packages/python-windows/README.txt: Remove the step telling the user to
> correct said version number.
> ]]]
Hm, this sounds good. +1, as long as you've tested it on Windows
Cheers,
David
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2377170