You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/21 18:38:25 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #10441: Fix docs build uploading artifacts

potiuk commented on a change in pull request #10441:
URL: https://github.com/apache/airflow/pull/10441#discussion_r474863556



##########
File path: tests/conftest.py
##########
@@ -38,11 +38,6 @@
     sys.path.append(perf_directory)
 
 
-from perf_kit.sqlalchemy import (  # noqa: E402 isort:skip # pylint: disable=wrong-import-position

Review comment:
       @mik-laj -> I had to move the import to inside the ExistStack class as perfkit is now not available when we run CI tests (it is in a separate directory so I have not added it to the image). It is still available when you local-mount the sources, so this shoudl not change interactive behavior. But I am not sure if this is correct - because maybe you rely on the import doing something at import time. Let me know if this is OK, ore whether we should find another solution.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org