[GitHub] carryxyh commented on a change in pull request #2197: [Dubbo-#2184] Return the hanging client requests immediately when connection is broken #2184

[GitBox <gi...@apache.org>]

carryxyh commented on a change in pull request #2197: [Dubbo-#2184] Return the hanging client requests immediately when connection is broken #2184
URL: https://github.com/apache/incubator-dubbo/pull/2197#discussion_r208142360
 
 

 ##########
 File path: dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java
 ##########
 @@ -107,6 +107,13 @@ public static void received(Channel channel, Response response) {
         }
     }
 
+    public static void disconnected(Channel channel) {
 
 Review comment:
   If the client connect to several server, DefaultFuture will keep all of the future which unfinished.
   This method will disconnect all the futures which bind to different server?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org