You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/18 10:11:32 UTC
[GitHub] [apisix-ingress-controller] shareinto opened a new pull request, #1394: fix: ingresstlssecretnotfound
shareinto opened a new pull request, #1394:
URL: https://github.com/apache/apisix-ingress-controller/pull/1394
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
https://github.com/apache/apisix-ingress-controller/issues/1387
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on pull request #1394: fix: ingresstlssecretnotfound
Posted by GitBox <gi...@apache.org>.
AlinsRan commented on PR #1394:
URL: https://github.com/apache/apisix-ingress-controller/pull/1394#issuecomment-1336603005
Please merge the latest branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1394: fix: ingresstlssecretnotfound
Posted by GitBox <gi...@apache.org>.
AlinsRan commented on code in PR #1394:
URL: https://github.com/apache/apisix-ingress-controller/pull/1394#discussion_r1039278171
##########
pkg/providers/controller.go:
##########
@@ -262,6 +262,16 @@ func (c *Controller) initSharedInformers() *providertypes.ListerInformer {
ConfigMapLister: configmapLister,
}
+ //wait for all informer has synecd
+ apisixFactory.Start(ctx.Done())
+ kubeFactory.Start(ctx.Done())
+ cache.WaitForCacheSync(ctx.Done(),
+ listerInformer.EpInformer.HasSynced,
+ listerInformer.SvcInformer.HasSynced,
+ listerInformer.SecretInformer.HasSynced,
+ listerInformer.PodInformer.HasSynced,
+ listerInformer.ApisixUpstreamInformer.HasSynced)
+
Review Comment:
It is wrong to start here, because the event handler function is not registered before starting, which will cause some events to be lost.
##########
pkg/providers/controller.go:
##########
@@ -262,6 +262,16 @@ func (c *Controller) initSharedInformers() *providertypes.ListerInformer {
ConfigMapLister: configmapLister,
}
+ //wait for all informer has synecd
+ apisixFactory.Start(ctx.Done())
+ kubeFactory.Start(ctx.Done())
+ cache.WaitForCacheSync(ctx.Done(),
+ listerInformer.EpInformer.HasSynced,
+ listerInformer.SvcInformer.HasSynced,
+ listerInformer.SecretInformer.HasSynced,
+ listerInformer.PodInformer.HasSynced,
+ listerInformer.ApisixUpstreamInformer.HasSynced)
+
Review Comment:
`apisixFactory.Start(ctx.Done())`
why is it needed？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1394: fix: ingresstlssecretnotfound
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1394:
URL: https://github.com/apache/apisix-ingress-controller/pull/1394#issuecomment-1336644182
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1394](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4705dea) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ed92690f5aabb4ece4b92d860d72d85bdfa23db0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed92690) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 4705dea differs from pull request most recent head 87b350b. Consider uploading reports for the commit 87b350b to get more accurate results
```diff
@@ Coverage Diff @@
## master #1394 +/- ##
==========================================
- Coverage 41.26% 41.24% -0.02%
==========================================
Files 83 83
Lines 7365 7365
==========================================
- Hits 3039 3038 -1
- Misses 3972 3973 +1
Partials 354 354
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `36.12% <100.00%> (ø)` | |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `64.13% <100.00%> (ø)` | |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `81.48% <0.00%> (-1.24%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1394: fix: ingresstlssecretnotfound
Posted by GitBox <gi...@apache.org>.
AlinsRan commented on code in PR #1394:
URL: https://github.com/apache/apisix-ingress-controller/pull/1394#discussion_r1039311313
##########
pkg/providers/controller.go:
##########
@@ -262,6 +262,16 @@ func (c *Controller) initSharedInformers() *providertypes.ListerInformer {
ConfigMapLister: configmapLister,
}
+ //wait for all informer has synecd
+ apisixFactory.Start(ctx.Done())
+ kubeFactory.Start(ctx.Done())
+ cache.WaitForCacheSync(ctx.Done(),
+ listerInformer.EpInformer.HasSynced,
+ listerInformer.SvcInformer.HasSynced,
+ listerInformer.SecretInformer.HasSynced,
+ listerInformer.PodInformer.HasSynced,
+ listerInformer.ApisixUpstreamInformer.HasSynced)
+
Review Comment:
Please take a look at it https://github.com/apache/apisix-ingress-controller/issues/1393#issuecomment-1336967425.
I think we can discuss it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1394: fix: ingress.tls secret not found
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1394:
URL: https://github.com/apache/apisix-ingress-controller/pull/1394#issuecomment-1345950358
as far as I know, @AlinsRan and @shareinto have verified this fix in @shareinto 's environment.
I will merge this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1394: fix: ingress.tls secret not found
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1394:
URL: https://github.com/apache/apisix-ingress-controller/pull/1394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org