You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/12/10 23:32:00 UTC
[jira] [Work logged] (GOBBLIN-1591) lazily initialize FileContext in Task commit
[ https://issues.apache.org/jira/browse/GOBBLIN-1591?focusedWorklogId=694334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694334 ]
ASF GitHub Bot logged work on GOBBLIN-1591:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/21 23:31
Start Date: 10/Dec/21 23:31
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3444:
URL: https://github.com/apache/gobblin/pull/3444#issuecomment-991372547
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3444](https://codecov.io/gh/apache/gobblin/pull/3444?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (604f028) into [master](https://codecov.io/gh/apache/gobblin/commit/65a3649474be1d8b5203c8cacb16b8e1bcd5455b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65a3649) will **decrease** coverage by `3.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3444 +/- ##
============================================
- Coverage 46.56% 43.42% -3.15%
+ Complexity 10325 2028 -8297
============================================
Files 2074 404 -1670
Lines 80889 17349 -63540
Branches 9025 2120 -6905
============================================
- Hits 37663 7533 -30130
+ Misses 39748 8980 -30768
+ Partials 3478 836 -2642
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| [...nt/copy/writer/FileAwareInputStreamDataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvd3JpdGVyL0ZpbGVBd2FyZUlucHV0U3RyZWFtRGF0YVdyaXRlci5qYXZh) | | |
| [.../java/org/apache/gobblin/state/ConstructState.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3N0YXRlL0NvbnN0cnVjdFN0YXRlLmphdmE=) | | |
| [...che/gobblin/qualitychecker/row/RowLevelPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcXVhbGl0eWNoZWNrZXIvcm93L1Jvd0xldmVsUG9saWN5LmphdmE=) | | |
| [...main/java/org/apache/gobblin/types/TypeMapper.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZXMvVHlwZU1hcHBlci5qYXZh) | | |
| [.../org/apache/gobblin/metrics/ContextAwareGauge.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Db250ZXh0QXdhcmVHYXVnZS5qYXZh) | | |
| [...org/apache/gobblin/scheduler/SchedulerService.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NjaGVkdWxlci9TY2hlZHVsZXJTZXJ2aWNlLmphdmE=) | | |
| [...uiteBaseWithConfigurableCompleteActionFactory.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZVdpdGhDb25maWd1cmFibGVDb21wbGV0ZUFjdGlvbkZhY3RvcnkuamF2YQ==) | | |
| [...obblin/data/management/policy/SelectAllPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BvbGljeS9TZWxlY3RBbGxQb2xpY3kuamF2YQ==) | | |
| [...e/modules/flowgraph/datanodes/fs/SftpDataNode.java](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2ZzL1NmdHBEYXRhTm9kZS5qYXZh) | | |
| ... and [1662 more](https://codecov.io/gh/apache/gobblin/pull/3444/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3444?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3444?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [65a3649...604f028](https://codecov.io/gh/apache/gobblin/pull/3444?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 694334)
Remaining Estimate: 0h
Time Spent: 10m
> lazily initialize FileContext in Task commit
> --------------------------------------------
>
> Key: GOBBLIN-1591
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1591
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> lazily initialize FileContext in Task commit and do not store the object because it is not cached and we cannot keep storing one FileContext for every Task created.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)