You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/09 01:23:15 UTC

[GitHub] [trafficserver] masaori335 opened a new pull request #7583: Rollback LAZY_BUF_ALLOC remove in HttpTunnel

masaori335 opened a new pull request #7583:
URL: https://github.com/apache/trafficserver/pull/7583


   This is partial revert of b4f8d1c2ca5895c81dd7137b11620e421c1e8582 which removed `LAZY_BUF_ALLOC`. 
   The MIOBuffer allocation change is fine, but the change in the HttpTunnel.cc might be a problem. 
   
   At the beginning of `HttpTunnel::consumer_reenable(HttpTunnelConsumer *c)`, the change is below
   ```
   -  if (p && p->alive
   - #ifndef LAZY_BUF_ALLOC
   -       && p->read_buffer->write_avail() > 0
   - #endif
   +  if (p && p->alive && p->read_buffer->write_avail() > 0
   ```
   https://github.com/apache/trafficserver/pull/5029/files#diff-fa7d3bd44e7a4b62e39f491b2cfa19b9f93b9fe7e20bdae1bcccd251b0583342L1275-L1278
   
   `LAZY_BUF_ALLOC` was defined prior to the commit, so the change is equivalent to 
   
   ```
   - if (p && p->alive)
   + if (p && p->alive && p->read_buffer->write_avail() > 0)
   ```
   
   This might change the behavior of the HTTP throttling when the read_buffer is full.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7583: Rollback LAZY_BUF_ALLOC remove in HttpTunnel

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7583:
URL: https://github.com/apache/trafficserver/pull/7583#issuecomment-815008532


   Cherry-picked to v9.0.x branch.
   Cherry-picked to v9.1.x branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7583: Rollback LAZY_BUF_ALLOC remove in HttpTunnel

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7583:
URL: https://github.com/apache/trafficserver/pull/7583#issuecomment-824372880


   Dangit, this didn't make it into 9.0.1 :-/.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop merged pull request #7583: Rollback LAZY_BUF_ALLOC remove in HttpTunnel

Posted by GitBox <gi...@apache.org>.
zwoop merged pull request #7583:
URL: https://github.com/apache/trafficserver/pull/7583


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] shinrich commented on pull request #7583: Rollback LAZY_BUF_ALLOC remove in HttpTunnel

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7583:
URL: https://github.com/apache/trafficserver/pull/7583#issuecomment-793309899


   If this makes the flow control happier, looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org