You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2010/06/21 19:19:23 UTC

[jira] Resolved: (HBASE-2756) MetaScanner.metaScan doesn't take configurations

     [ https://issues.apache.org/jira/browse/HBASE-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans resolved HBASE-2756.
---------------------------------------

    Hadoop Flags: [Reviewed]
      Resolution: Fixed

I committed only the fix to trunk, and I'm moving the test to HBASE-2741 (else it will add a breaking test and Stack is trying to get it green).

> MetaScanner.metaScan doesn't take configurations
> ------------------------------------------------
>
>                 Key: HBASE-2756
>                 URL: https://issues.apache.org/jira/browse/HBASE-2756
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2756.patch
>
>
> HBASE-2468 added a bunch of code in MetaScanner.metaScan, and this particular line is wrong:
> {code}
> +    // if row is not null, we want to use the startKey of the row's region as
> +    // the startRow for the meta scan.
> +    if (row != null) {
> +      HTable metaTable = new HTable(HConstants.META_TABLE_NAME);   <<<<<<<<<<<<<<<<<
> +      Result startRowResult = metaTable.getRowOrBefore(startRow,
> +          HConstants.CATALOG_FAMILY);
> +      if (startRowResult == null) {
> {code}
> If the user specified any new configuration in his code, like ZK's parent znode, then it will miss it. This should use the HTable constructor that takes a Configuration and pass the one it already has.
> I found this with my TestReplication test in HBASE-2223.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.