Re: [PR] [CALCITE-6967] Unparsing STARTS_WITH/ENDS_WITH/BIT functions is incorrect for the Clickhouse dialect [calcite]

["xuzifu666 (via GitHub)" <gi...@apache.org>]

xuzifu666 commented on code in PR #4314:
URL: https://github.com/apache/calcite/pull/4314#discussion_r2051449386


##########
site/_docs/reference.md:
##########
@@ -2876,7 +2878,7 @@ In the following:
 | b | DATE_TRUNC(date, timeUnit)                     | Truncates *date* to the granularity of *timeUnit*, rounding to the beginning of the unit
 | o r s h | DECODE(value, value1, result1 [, valueN, resultN ]* [, default ]) | Compares *value* to each *valueN* value one by one; if *value* is equal to a *valueN*, returns the corresponding *resultN*, else returns *default*, or NULL if *default* is not specified
 | p r | DIFFERENCE(string, string)                   | Returns a measure of the similarity of two strings, namely the number of character positions that their `SOUNDEX` values have in common: 4 if the `SOUNDEX` values are same and 0 if the `SOUNDEX` values are totally different
-| f s | ENDSWITH(string1, string2)                   | Returns whether *string2* is a suffix of *string1*
+| f s i | ENDSWITH(string1, string2)                 | Returns whether *string2* is a suffix of *string1*

Review Comment:
   Thanks for review, I had test with remove the document and would error out due to the document checker, error message is:
   ```
   java.lang.AssertionError: some functions are not documented: ENDSWITH(\| [^|]*i[^|]* \| .*ENDSWITH\(.*), STARTSWITH(\| [^|]*i[^|]* \| .*STARTSWITH\(.*)
   Expected: is <true>
        but: was <false>
   	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
   	at org.apache.calcite.sql.test.DocumentationTest.testAllFunctionsAreDocumented(DocumentationTest.java:142)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
   	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
   	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
   	at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45)
   	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
   	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)
   	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)
   	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)
   	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java
   ```
   
   because startswith/endswith is not in SqlStdOperatorTable, so need to be added by dialects, and if not doc them would produce document error. @NobiGo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org