You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Neels J Hofmeyr <ne...@elego.de> on 2008/11/25 05:55:24 UTC
tree-conflicts: svn_wc_conflict_description_create_tree()
In svn_wc_conflict_description_create_tree(), shouldn't the ACTION and
REASON be arguments to the function?
[[[
conflict = svn_wc_conflict_description_create_tree(
full_path, parent_adm_access, entry->kind,
eb->switch_url ? svn_wc_operation_switch : svn_wc_operation_update,
src_left_version, src_right_version, pool);
conflict->action = action;
conflict->reason = reason;
]]]
It's a lot of zombie work, however.
~Neels
Re: tree-conflicts: svn_wc_conflict_description_create_tree()
Posted by Julian Foad <ju...@btopenworld.com>.
On Tue, 2008-11-25 at 06:55 +0100, Neels J Hofmeyr wrote:
> In svn_wc_conflict_description_create_tree(), shouldn't the ACTION and
> REASON be arguments to the function?
Yes, that would be better...
> [[[
> conflict = svn_wc_conflict_description_create_tree(
> full_path, parent_adm_access, entry->kind,
> eb->switch_url ? svn_wc_operation_switch : svn_wc_operation_update,
> src_left_version, src_right_version, pool);
> conflict->action = action;
> conflict->reason = reason;
> ]]]
>
> It's a lot of zombie work, however.
... but it's not critical.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org