You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/16 09:19:42 UTC
[GitHub] [kafka] dajac opened a new pull request, #12864: MINOR: Handle JoinGroupResponseData.protocolName backward compatibility in JoinGroupResponse
dajac opened a new pull request, #12864:
URL: https://github.com/apache/kafka/pull/12864
This is a small refactor extracted from https://github.com/apache/kafka/pull/12845. It basically moves the logic to handle the backward compatibility of `JoinGroupResponseData.protocolName` from `KafkaApis` to `JoinGroupResponse`.
The patch adds a new unit test for `JoinGroupResponse` and relies on existing tests as well.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12864: MINOR: Handle JoinGroupResponseData.protocolName backward compatibility in JoinGroupResponse
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12864:
URL: https://github.com/apache/kafka/pull/12864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a diff in pull request #12864: MINOR: Handle JoinGroupResponseData.protocolName backward compatibility in JoinGroupResponse
Posted by GitBox <gi...@apache.org>.
dajac commented on code in PR #12864:
URL: https://github.com/apache/kafka/pull/12864#discussion_r1023727410
##########
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java:
##########
@@ -28,9 +28,15 @@ public class JoinGroupResponse extends AbstractResponse {
private final JoinGroupResponseData data;
- public JoinGroupResponse(JoinGroupResponseData data) {
+ public JoinGroupResponse(JoinGroupResponseData data, short version) {
super(ApiKeys.JOIN_GROUP);
this.data = data;
+
+ // All versions prior to version 7 do not support nullable
+ // string for the protocol name. Empty string should be used.
+ if (version < 7 && data.protocolName() == null) {
+ data.setProtocolName("");
+ }
Review Comment:
This new logic replaces https://github.com/apache/kafka/pull/12864/files#diff-cc056b4960ededba37a438b1454f0f3c5ff5e8ad5e6d2ec9a08e813ca056ffebL1655.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org