You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/07 22:57:08 UTC

[native-toolchain-CR] Use git:// protocol to clone kudu

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12303 )

Change subject: Use git:// protocol to clone kudu
......................................................................


Patch Set 2:

I'm not too up-to-speed with the pros and cons of different git protocols. I understand git:// has some security limitations.

I believe all of the platforms that build Kudu can connect to github over ssh.


-- 
To view, visit http://gerrit.cloudera.org:8080/12303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
Gerrit-Change-Number: 12303
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:57:08 +0000
Gerrit-HasComments: No