[GitHub] [arrow-rs] wjones127 commented on a diff in pull request #4475: feat: support RecordBatchReader on boxed trait objects

["wjones127 (via GitHub)" <gi...@apache.org>]

wjones127 commented on code in PR #4475:
URL: https://github.com/apache/arrow-rs/pull/4475#discussion_r1249211662


##########
arrow/src/ffi_stream.rs:
##########
@@ -157,7 +157,7 @@ impl Drop for FFI_ArrowArrayStream {
 
 impl FFI_ArrowArrayStream {
     /// Creates a new [`FFI_ArrowArrayStream`].
-    pub fn new(batch_reader: Box<dyn RecordBatchReader>) -> Self {
+    pub fn new(batch_reader: Box<dyn RecordBatchReader + Send>) -> Self {

Review Comment:
   This is sort of a bug fix to get in compliant with the released API, but in a direct sense it is breaking, so maybe this should be labelled as breaking change? Not sure 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org