You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/09/22 20:45:47 UTC
Review Request 25863: Rename stout/os/setns.hpp to namespaces.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
Description
-------
Also, added os::getns(pid, ns) to get the namespace inode for comparisons between pids' namespaces.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am db9766d70adb9076946cd2b467c55636fe5f7235
3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de53c3873ecd0b62a08ca9aac530043ffb9
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b741bdd7f089ba93bf6fea43b9f39f8f0edb
3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 5278996f201a4a3d69282c1bd7b0d230d0f6cd39
3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ad8e37aa2f5a29f8b421dde6b7cd5dfe241eabb5
src/slave/containerizer/isolators/network/port_mapping.cpp 9248460caa558e43a2a7d237f6a37d43f0eeacb5
Diff: https://reviews.apache.org/r/25863/diff/
Testing
-------
Added test to check a clone(NEW_PIDNS) results in a new pid namespace.
Thanks,
Ian Downes
Re: Review Request 25863: Rename stout/os/setns.hpp to namespaces.hpp.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/#review54306
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp
<https://reviews.apache.org/r/25863/#comment94390>
Add a new line above?
- Jie Yu
On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25863/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 6:45 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also, added os::getns(pid, ns) to get the namespace inode for comparisons between pids' namespaces.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am db9766d70adb9076946cd2b467c55636fe5f7235
> 3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de53c3873ecd0b62a08ca9aac530043ffb9
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b741bdd7f089ba93bf6fea43b9f39f8f0edb
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 5278996f201a4a3d69282c1bd7b0d230d0f6cd39
> 3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ad8e37aa2f5a29f8b421dde6b7cd5dfe241eabb5
> src/slave/containerizer/isolators/network/port_mapping.cpp 9248460caa558e43a2a7d237f6a37d43f0eeacb5
>
> Diff: https://reviews.apache.org/r/25863/diff/
>
>
> Testing
> -------
>
> Added test to check a clone(NEW_PIDNS) results in a new pid namespace.
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25863: Rename stout/os/setns.hpp to namespaces.hpp.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/#review54193
-----------------------------------------------------------
Patch looks great!
Reviews applied: [25863]
All tests passed.
- Mesos ReviewBot
On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25863/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 6:45 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also, added os::getns(pid, ns) to get the namespace inode for comparisons between pids' namespaces.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am db9766d70adb9076946cd2b467c55636fe5f7235
> 3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de53c3873ecd0b62a08ca9aac530043ffb9
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b741bdd7f089ba93bf6fea43b9f39f8f0edb
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 5278996f201a4a3d69282c1bd7b0d230d0f6cd39
> 3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ad8e37aa2f5a29f8b421dde6b7cd5dfe241eabb5
> src/slave/containerizer/isolators/network/port_mapping.cpp 9248460caa558e43a2a7d237f6a37d43f0eeacb5
>
> Diff: https://reviews.apache.org/r/25863/diff/
>
>
> Testing
> -------
>
> Added test to check a clone(NEW_PIDNS) results in a new pid namespace.
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25863: Rename stout/os/setns.hpp to namespaces.hpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/#review54630
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 23, 2014, 11:39 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25863/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 11:39 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also, added os::getns(pid, ns) to get the namespace inode for comparisons between pids' namespaces.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am d4a8ad4e776bcfe1f008e561b5a92340f4d84bd9
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 5278996f201a4a3d69282c1bd7b0d230d0f6cd39
> 3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ad8e37aa2f5a29f8b421dde6b7cd5dfe241eabb5
>
> Diff: https://reviews.apache.org/r/25863/diff/
>
>
> Testing
> -------
>
> Added test to check a clone(NEW_PIDNS) results in a new pid namespace.
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25863: Rename stout/os/setns.hpp to namespaces.hpp.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/
-----------------------------------------------------------
(Updated Sept. 23, 2014, 4:39 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
Description
-------
Also, added os::getns(pid, ns) to get the namespace inode for comparisons between pids' namespaces.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e
3rdparty/libprocess/3rdparty/stout/include/Makefile.am d4a8ad4e776bcfe1f008e561b5a92340f4d84bd9
3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 5278996f201a4a3d69282c1bd7b0d230d0f6cd39
3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ad8e37aa2f5a29f8b421dde6b7cd5dfe241eabb5
Diff: https://reviews.apache.org/r/25863/diff/
Testing
-------
Added test to check a clone(NEW_PIDNS) results in a new pid namespace.
Thanks,
Ian Downes