You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/07/15 11:16:49 UTC

Review Request 12544: CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12544/
-----------------------------------------------------------

Review request for cloudstack and Devdeep Singh.


Bugs: CLOUDSTACK-3496


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.

Issue caused because of the change in storage design as a part of object_store branch, fixed the check accordingly.


Diffs
-----

  server/src/com/cloud/storage/VolumeManagerImpl.java 72d27bc 

Diff: https://reviews.apache.org/r/12544/diff/


Testing
-------

Tests:

1. Create a volume.
2. Check the primaryStorageTotal value by calling listAccounts&id= .
3. Attach this volume to an instance.
4. Detach this volume and delete it.
5. Again check the primayStorageTotal.

Verified the fix by following the above mentioned steps.


Thanks,

Sanjay Tripathi

Re: Review Request 12544: CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12544/#review23495
-----------------------------------------------------------


Commit 3771e8a0e61385aa6bda0fd73afa961b6a6cb091 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3771e8a ]

CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted


- ASF Subversion and Git Services


On July 15, 2013, 9:16 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12544/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3496
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.
> 
> Issue caused because of the change in storage design as a part of object_store branch, fixed the check accordingly.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 72d27bc 
> 
> Diff: https://reviews.apache.org/r/12544/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 
> 1. Create a volume.
> 2. Check the primaryStorageTotal value by calling listAccounts&id= .
> 3. Attach this volume to an instance.
> 4. Detach this volume and delete it.
> 5. Again check the primayStorageTotal.
> 
> Verified the fix by following the above mentioned steps.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 12544: CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12544/#review23498
-----------------------------------------------------------


Commit a98c0f5b89533e9e8d3ef671c994ff9528aa5665 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a98c0f5 ]

CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted


- ASF Subversion and Git Services


On July 15, 2013, 9:16 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12544/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3496
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.
> 
> Issue caused because of the change in storage design as a part of object_store branch, fixed the check accordingly.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 72d27bc 
> 
> Diff: https://reviews.apache.org/r/12544/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 
> 1. Create a volume.
> 2. Check the primaryStorageTotal value by calling listAccounts&id= .
> 3. Attach this volume to an instance.
> 4. Detach this volume and delete it.
> 5. Again check the primayStorageTotal.
> 
> Verified the fix by following the above mentioned steps.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 12544: CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12544/#review23503
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On July 15, 2013, 9:16 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12544/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3496
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3496: [Regression]Primary Storage resource usage is not getting updated if detached volume is deleted.
> 
> Issue caused because of the change in storage design as a part of object_store branch, fixed the check accordingly.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 72d27bc 
> 
> Diff: https://reviews.apache.org/r/12544/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 
> 1. Create a volume.
> 2. Check the primaryStorageTotal value by calling listAccounts&id= .
> 3. Attach this volume to an instance.
> 4. Detach this volume and delete it.
> 5. Again check the primayStorageTotal.
> 
> Verified the fix by following the above mentioned steps.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>