You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xbean-dev@geronimo.apache.org by "Peter Kofler (JIRA)" <ji...@apache.org> on 2011/09/06 23:19:10 UTC
[jira] [Created] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Move OSGI dependency of XBEAN Finder (to Bundle Utils)
------------------------------------------------------
Key: XBEAN-186
URL: https://issues.apache.org/jira/browse/XBEAN-186
Project: XBean
Issue Type: Improvement
Reporter: Peter Kofler
The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Posted by "Peter Kofler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Kofler updated XBEAN-186:
-------------------------------
Attachment: XBEAN-186.patch
User code might have to invert Maven dependencies. If you need OSGI finder logic you need to add bundleutils on top of finder. Class names of moved classes are the same.
Most likely bundleutils are used as runtime dependency in Maven anyway, so no changes should be required for user projects.
> Move OSGI dependency of XBEAN Finder (to Bundle Utils)
> ------------------------------------------------------
>
> Key: XBEAN-186
> URL: https://issues.apache.org/jira/browse/XBEAN-186
> Project: XBean
> Issue Type: Improvement
> Reporter: Peter Kofler
> Attachments: XBEAN-186.patch
>
>
> The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Posted by "Peter Kofler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Kofler updated XBEAN-186:
-------------------------------
Component/s: finder
bundleutils
Issue Type: Wish (was: Improvement)
> Move OSGI dependency of XBEAN Finder (to Bundle Utils)
> ------------------------------------------------------
>
> Key: XBEAN-186
> URL: https://issues.apache.org/jira/browse/XBEAN-186
> Project: XBean
> Issue Type: Wish
> Components: bundleutils, finder
> Reporter: Peter Kofler
> Attachments: XBEAN-186.patch
>
>
> The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Posted by "Peter Kofler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098763#comment-13098763 ]
Peter Kofler commented on XBEAN-186:
------------------------------------
>I don't understand why this is an improvement. I think its just as likely that someone wants to use bundleutils without the finder as finder without osgi.
You are right. Better would be a "pure" finder, finder-OSGI (which depends on bundleutils) and bundleutils. So both packages would be low-level. On the other hand a new module with just 3 classes seems a bit of an overhead for an OSGI-finder.
Please note that our "hidden" agenda is to free finder of all dependencies, so it could be used as a starting point of commons-classscan (or similar). commons-classscan should not depend on OSGI, just on asm and later bcel. So I agree with Mark that the basic finder without OSGI should be the target.
So if you do not think inverting the dependencies is a good idea, then we could create a new module, call it finder-bundle-extension or sth. It's similar easy and could be done quickly. But as I said, that does not feel proper for me, as this module would be anemic.
> Move OSGI dependency of XBEAN Finder (to Bundle Utils)
> ------------------------------------------------------
>
> Key: XBEAN-186
> URL: https://issues.apache.org/jira/browse/XBEAN-186
> Project: XBean
> Issue Type: Improvement
> Reporter: Peter Kofler
> Attachments: XBEAN-186.patch
>
>
> The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098437#comment-13098437 ]
Mark Struberg commented on XBEAN-186:
-------------------------------------
finder without osgi is the standard imo. We have this problem when we like to use xbean-finder in OWB as replacement for scannotation. In 95% of all usages OWB and OpenEJB are _not_ used in OSGi environments...
> Move OSGI dependency of XBEAN Finder (to Bundle Utils)
> ------------------------------------------------------
>
> Key: XBEAN-186
> URL: https://issues.apache.org/jira/browse/XBEAN-186
> Project: XBean
> Issue Type: Improvement
> Reporter: Peter Kofler
> Attachments: XBEAN-186.patch
>
>
> The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Posted by "Peter Kofler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Kofler updated XBEAN-186:
-------------------------------
Attachment: XBEAN-186_fixed.patch
SVN does not show moved files in diff, so the first patch is broken because it only deletes the 3 bundle finder classes. I created a new patch that simply deletes and add these files again, which works as expected.
> Move OSGI dependency of XBEAN Finder (to Bundle Utils)
> ------------------------------------------------------
>
> Key: XBEAN-186
> URL: https://issues.apache.org/jira/browse/XBEAN-186
> Project: XBean
> Issue Type: Wish
> Components: bundleutils, finder
> Reporter: Peter Kofler
> Attachments: XBEAN-186.patch, XBEAN-186_fixed.patch
>
>
> The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098415#comment-13098415 ]
David Jencks commented on XBEAN-186:
------------------------------------
I don't understand why this is an improvement. I think its just as likely that someone wants to use bundleutils without the finder as finder without osgi. Can you explain the problem you are trying to solve and why the problems you create are less severe?
> Move OSGI dependency of XBEAN Finder (to Bundle Utils)
> ------------------------------------------------------
>
> Key: XBEAN-186
> URL: https://issues.apache.org/jira/browse/XBEAN-186
> Project: XBean
> Issue Type: Improvement
> Reporter: Peter Kofler
> Attachments: XBEAN-186.patch
>
>
> The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (XBEAN-186) Move OSGI dependency of XBEAN Finder
(to Bundle Utils)
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XBEAN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098453#comment-13098453 ]
Mark Struberg commented on XBEAN-186:
-------------------------------------
I checked the usages in xbean and geronimo. xbeanutils is only used in xbean-finder atm. And if some external project uses internal classes, then he hopefully knows what to do anyway...
So it's perfectly ok and safe to reverse the dependencies imo.
> Move OSGI dependency of XBEAN Finder (to Bundle Utils)
> ------------------------------------------------------
>
> Key: XBEAN-186
> URL: https://issues.apache.org/jira/browse/XBEAN-186
> Project: XBean
> Issue Type: Improvement
> Reporter: Peter Kofler
> Attachments: XBEAN-186.patch
>
>
> The XBEAN Finder is depending on OSGI and xbean-bundleutils. This is not desireable. We invert the dependency so that all Finder logic that uses OSGI is moved into bundleutils and bundleutils depends on finder then. So the finder is general without any dependencies and the OSGI finder logic is in bundleutils.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira