You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2019/11/27 22:19:20 UTC

[Impala-ASF-CR] IMPALA-9202: Fix flakiness in test executor groups

Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14810


Change subject: IMPALA-9202: Fix flakiness in test_executor_groups
......................................................................

IMPALA-9202: Fix flakiness in test_executor_groups

Some tests in test_executor_groups immediately tried fetching the query
profile after executing it asynchronously to verify if the query was
queued. However there is a small window between the exec rpc returning
and the query being queued during which the query profile does not
contain any info about the query being queued. This was causing some
asserts in the test to fail.

Change-Id: I47070045250a12d86c99f9a30a956a268be5fa7e
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 15 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14810/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47070045250a12d86c99f9a30a956a268be5fa7e
Gerrit-Change-Number: 14810
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9202: Fix flakiness in test executor groups

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.

Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14810 )

Change subject: IMPALA-9202: Fix flakiness in test_executor_groups
......................................................................


Patch Set 1: Code-Review+1

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/14810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47070045250a12d86c99f9a30a956a268be5fa7e
Gerrit-Change-Number: 14810
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Nov 2019 22:51:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9202: Fix flakiness in test executor groups

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.

Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14810 )

Change subject: IMPALA-9202: Fix flakiness in test_executor_groups
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py@117
PS1, Line 117:     """Assert with a timeout of 60 sec and a polling interval of 1 sec that the
> nit: maybe mention that the 1 is the interval?
Done


http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py@120
PS1, Line 120:       60, 1, lambda: expected_str in self.client.get_runtime_profile(query_handle))
> nit: maybe indent in a more pythonic way (start under the 6)
fixed the formatting.
I tried following how assert_eventually was being used elsewhere in the code, that is, passing a lambda to it. I dont have a preference either way so will keep this unchanged for now.



-- 
To view, visit http://gerrit.cloudera.org:8080/14810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47070045250a12d86c99f9a30a956a268be5fa7e
Gerrit-Change-Number: 14810
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Dec 2019 19:02:59 +0000
Gerrit-HasComments: Yes