You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/12/15 16:42:56 UTC
[GitHub] [lucene-solr] jbampton commented on a change in pull request #2121: SOLR-10860: Return proper error code for bad input incase of inplace updates
jbampton commented on a change in pull request #2121:
URL: https://github.com/apache/lucene-solr/pull/2121#discussion_r543503718
##########
File path: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
##########
@@ -143,6 +147,15 @@ public SolrInputDocument merge(final SolrInputDocument fromDoc, SolrInputDocumen
return toDoc;
}
+ private static String getID(SolrInputDocument doc, IndexSchema schema) {
+ String id = "";
+ SchemaField sf = schema.getUniqueKeyField();
+ if( sf != null ) {
Review comment:
```suggestion
if ( sf != null ) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org