[GitHub] nitin-maharana commented on a change in pull request #2574: [CLOUDSTACK-5235] ask users old password when they are executing a password update

[GitBox <gi...@apache.org>]

nitin-maharana commented on a change in pull request #2574: [CLOUDSTACK-5235] ask users old password when they are executing a password update
URL: https://github.com/apache/cloudstack/pull/2574#discussion_r182028887
 
 

 ##########
 File path: api/src/main/java/com/cloud/user/AccountService.java
 ##########
 @@ -23,53 +23,28 @@
 import org.apache.cloudstack.acl.SecurityChecker.AccessType;
 import org.apache.cloudstack.api.command.admin.user.GetUserKeysCmd;
 import org.apache.cloudstack.api.command.admin.user.RegisterCmd;
+import org.apache.cloudstack.api.command.admin.user.UpdateUserCmd;
 
 import com.cloud.domain.Domain;
 import com.cloud.exception.PermissionDeniedException;
 import com.cloud.offering.DiskOffering;
 import com.cloud.offering.ServiceOffering;
 
-
 public interface AccountService {
 
     /**
      * Creates a new user and account, stores the password as is so encrypted passwords are recommended.
-     *
 
 Review comment:
   @rafaelweingartner, Thanks for the fix. I think it's better to keep the comments, would be helpful in the documentation. Would be great if you describe a bit about each parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services