You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "John Vines (Created) (JIRA)" <ji...@apache.org> on 2011/11/29 20:41:40 UTC
[jira] [Created] (RAT-108) Add native support for thrift generated
code to be ignored
Add native support for thrift generated code to be ignored
----------------------------------------------------------
Key: RAT-108
URL: https://issues.apache.org/jira/browse/RAT-108
Project: RAT
Issue Type: Improvement
Components: engine
Affects Versions: 0.8
Reporter: John Vines
Priority: Minor
It appears as though RAT does not include the standard Thrift headers in the exclusion list in GeneratedLicenseNotRequired and it probably should be.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-108) Add native support for thrift
generated code to be ignored
Posted by "David Crossley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159836#comment-13159836 ]
David Crossley commented on RAT-108:
------------------------------------
I committed your patch. If that solves it for you, then please close.
> Add native support for thrift generated code to be ignored
> ----------------------------------------------------------
>
> Key: RAT-108
> URL: https://issues.apache.org/jira/browse/RAT-108
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Affects Versions: 0.8
> Reporter: John Vines
> Priority: Minor
> Labels: generated, thrift
>
> It appears as though RAT does not include the standard Thrift headers in the exclusion list in GeneratedLicenseNotRequired and it probably should be.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAT-108) Add native support for thrift generated
code to be ignored
Posted by "John Vines (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Vines resolved RAT-108.
----------------------------
Resolution: Fixed
Fix Version/s: 0.9
My patch seemed to work, at least for thrift 0.6 generated code, but I think the expression should work for thrift .7 code as well.
> Add native support for thrift generated code to be ignored
> ----------------------------------------------------------
>
> Key: RAT-108
> URL: https://issues.apache.org/jira/browse/RAT-108
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Affects Versions: 0.8
> Reporter: John Vines
> Priority: Minor
> Labels: generated, thrift
> Fix For: 0.9
>
>
> It appears as though RAT does not include the standard Thrift headers in the exclusion list in GeneratedLicenseNotRequired and it probably should be.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-108) Add native support for thrift
generated code to be ignored
Posted by "John Vines (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159483#comment-13159483 ]
John Vines commented on RAT-108:
--------------------------------
I like to think it's as straightforward as-
Index: src/main/java/org/apache/rat/analysis/generation/GeneratedLicenseNotRequired.java
===================================================================
--- src/main/java/org/apache/rat/analysis/generation/GeneratedLicenseNotRequired.java (revision 1208038)
+++ src/main/java/org/apache/rat/analysis/generation/GeneratedLicenseNotRequired.java (working copy)
@@ -48,7 +48,8 @@
Pattern.compile(".*this file is autogenerated.*"),
Pattern.compile(".*This class was autogenerated.*"),
Pattern.compile(".*Generated by Maven.*"),
+ Pattern.compile(".*Autogenerated by Thrift.*"),
Pattern.compile(".*This class was generated by.*")};
private final Pattern[] linePatterns;
> Add native support for thrift generated code to be ignored
> ----------------------------------------------------------
>
> Key: RAT-108
> URL: https://issues.apache.org/jira/browse/RAT-108
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Affects Versions: 0.8
> Reporter: John Vines
> Priority: Minor
> Labels: generated, thrift
>
> It appears as though RAT does not include the standard Thrift headers in the exclusion list in GeneratedLicenseNotRequired and it probably should be.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira