You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/02 18:44:59 UTC

[GitHub] [fineract] vorburger opened a new pull request #799: use throw instead of confusing return null inside catch

vorburger opened a new pull request #799:
URL: https://github.com/apache/fineract/pull/799


   in JournalEntryWritePlatformServiceJpaRepositoryImpl


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #799: use throw instead of confusing return null inside catch

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #799:
URL: https://github.com/apache/fineract/pull/799#issuecomment-622998209


   @awasum how about this? It's apparently done wrong (pattern) in many classes in the code.
   
   @maektwain FYI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] maektwain commented on pull request #799: use throw instead of confusing return null inside catch

Posted by GitBox <gi...@apache.org>.
maektwain commented on pull request #799:
URL: https://github.com/apache/fineract/pull/799#issuecomment-622999840


   Gotcha , should I wait for this to be merged? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #799: use throw instead of confusing return null inside catch

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #799:
URL: https://github.com/apache/fineract/pull/799#issuecomment-623021864


   @maektwain I've just self merged it, assuming no objections, to unblock you so that you can rebase.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] maektwain commented on pull request #799: use throw instead of confusing return null inside catch

Posted by GitBox <gi...@apache.org>.
maektwain commented on pull request #799:
URL: https://github.com/apache/fineract/pull/799#issuecomment-623006751


   We should gtmit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org