You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (Created) (JIRA)" <ji...@apache.org> on 2011/09/28 02:02:45 UTC
[jira] [Created] (HBASE-4503) Purge deprecated HBaseClusterTestCase
Purge deprecated HBaseClusterTestCase
-------------------------------------
Key: HBASE-4503
URL: https://issues.apache.org/jira/browse/HBASE-4503
Project: HBase
Issue Type: Improvement
Reporter: stack
It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117768#comment-13117768 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/#review2196
-----------------------------------------------------------
Ship it!
- Jesse
On 2011-09-29 23:26:34, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2119/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 23:26:34)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Replace deprecated HBaseClusterTestCase and subclasses.
bq.
bq.
bq. This addresses bug hbase-4503.
bq. https://issues.apache.org/jira/browse/hbase-4503
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
bq. src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
bq. src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
bq. src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
bq. src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java d7baba4
bq. src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
bq. src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java 27842ed
bq. src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java 5a5c3c6
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 0b8ff30
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java a772360
bq. src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java a4cd9a3
bq. src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java 5b8b464
bq. src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 5802686
bq.
bq. Diff: https://reviews.apache.org/r/2119/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117653#comment-13117653 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/
-----------------------------------------------------------
(Updated 2011-09-29 22:01:14.094149)
Review request for hbase.
Changes
-------
Include actual diff
Summary
-------
Replace deprecated HBaseClusterTestCase and subclasses.
This addresses bug hbase-4503.
https://issues.apache.org/jira/browse/hbase-4503
Diffs (updated)
-----
src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java 555174a
src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java d7baba4
src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java 27842ed
src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java 5a5c3c6
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 0b8ff30
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java a772360
src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java a4cd9a3
src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java 5b8b464
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 5802686
Diff: https://reviews.apache.org/r/2119/diff
Testing
-------
Unit tests pass
Thanks,
Michael
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117755#comment-13117755 ]
stack commented on HBASE-4503:
------------------------------
All unit tests passed when I ran with the first version of this patch.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117705#comment-13117705 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
bq. On 2011-09-29 22:26:55, Jesse Yates wrote:
bq. > src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java, line 150
bq. > <https://reviews.apache.org/r/2119/diff/1/?file=46504#file46504line150>
bq. >
bq. > Does this file really need to be here? Yeah, its a little whitespace cleanup, but I don't think its *that* necessary
Agreed. Will purge it from the diff.
bq. On 2011-09-29 22:26:55, Jesse Yates wrote:
bq. > src/test/java/org/apache/hadoop/hbase/TestInfoServers.java, line 105
bq. > <https://reviews.apache.org/r/2119/diff/1/?file=46505#file46505line105>
bq. >
bq. > why not just assertEquals(${desc}, expected, content) here?
Will do.
bq. On 2011-09-29 22:26:55, Jesse Yates wrote:
bq. > src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java, line 72
bq. > <https://reviews.apache.org/r/2119/diff/1/?file=46506#file46506line72>
bq. >
bq. > Couldn't this just go into @BeforeClass?
That is static but this.admin is not. It could but saw no harm doing it this way.
bq. On 2011-09-29 22:26:55, Jesse Yates wrote:
bq. > src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java, line 240
bq. > <https://reviews.apache.org/r/2119/diff/1/?file=46506#file46506line240>
bq. >
bq. > nitpick: just use iterable properties here?
bq. >
bq. > Also, maybe abstract this into a single checking method? Not gaining a whole lot, but saves you some code copy.
The tests here were copied from elsewhere. I tried not to touch what they did, just convert the chassis they used. I can change this np.
bq. On 2011-09-29 22:26:55, Jesse Yates wrote:
bq. > src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java, line 191
bq. > <https://reviews.apache.org/r/2119/diff/1/?file=46513#file46513line191>
bq. >
bq. > nitpick: why drop the import?
Will fix.
bq. On 2011-09-29 22:26:55, Jesse Yates wrote:
bq. > src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java, line 217
bq. > <https://reviews.apache.org/r/2119/diff/1/?file=46514#file46514line217>
bq. >
bq. > nitpick: (Again) import Assert.*?
Will fix.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/#review2184
-----------------------------------------------------------
On 2011-09-29 22:01:14, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2119/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 22:01:14)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Replace deprecated HBaseClusterTestCase and subclasses.
bq.
bq.
bq. This addresses bug hbase-4503.
bq. https://issues.apache.org/jira/browse/hbase-4503
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
bq. src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
bq. src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java 555174a
bq. src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
bq. src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
bq. src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java d7baba4
bq. src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
bq. src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java 27842ed
bq. src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java 5a5c3c6
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 0b8ff30
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java a772360
bq. src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java a4cd9a3
bq. src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java 5b8b464
bq. src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 5802686
bq.
bq. Diff: https://reviews.apache.org/r/2119/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117736#comment-13117736 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/
-----------------------------------------------------------
(Updated 2011-09-29 23:26:34.774487)
Review request for hbase.
Changes
-------
v3 addresses Jesse's feedback.
+ Removed the files TestHBaseTestingUtility.java and TestDefaultLoadBalancer.java from the diff.
+ Changed the check and throw of an IOE to just an assertTrue in TestInfoServers.java
+ Added imports for Assert.* in a few files.
I did not change guts of tests. Thats outside scope of this chassis-changing patch.
Summary
-------
Replace deprecated HBaseClusterTestCase and subclasses.
This addresses bug hbase-4503.
https://issues.apache.org/jira/browse/hbase-4503
Diffs (updated)
-----
src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java d7baba4
src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java 27842ed
src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java 5a5c3c6
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 0b8ff30
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java a772360
src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java a4cd9a3
src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java 5b8b464
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 5802686
Diff: https://reviews.apache.org/r/2119/diff
Testing
-------
Unit tests pass
Thanks,
Michael
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117627#comment-13117627 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Replace deprecated HBaseClusterTestCase and subclasses.
This addresses bug hbase-4503.
https://issues.apache.org/jira/browse/hbase-4503
Diffs
-----
Diff: https://reviews.apache.org/r/2119/diff
Testing
-------
Unit tests pass
Thanks,
Michael
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117036#comment-13117036 ]
stack commented on HBASE-4503:
------------------------------
Will post to RB in morn after I give it another run though.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4503) Purge deprecated HBaseClusterTestCase
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4503:
-------------------------
Attachment: 4503-v2.txt
This should do it. Removes HBaseClusterTestCase and the MultiTable thingy used by MR. Groups a few of old dependent tests and leaves other alone. Should save us a few minutes. Only 120+ to go.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4503) Purge deprecated HBaseClusterTestCase
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4503:
-------------------------
Attachment: 4503.txt
Here are a few tests converted. Few more to do.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Attachments: 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4503.
--------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Hadoop Flags: Reviewed
Committed to 0.92 and to trunk. Thanks for reviews Jesse, Ram, and Ted.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.92.0
>
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "stack (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-4503:
----------------------------
Assignee: stack
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117704#comment-13117704 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/#review2189
-----------------------------------------------------------
src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java
<https://reviews.apache.org/r/2119/#comment5109>
You are right
- Michael
On 2011-09-29 22:01:14, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2119/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 22:01:14)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Replace deprecated HBaseClusterTestCase and subclasses.
bq.
bq.
bq. This addresses bug hbase-4503.
bq. https://issues.apache.org/jira/browse/hbase-4503
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
bq. src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
bq. src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java 555174a
bq. src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
bq. src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
bq. src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java d7baba4
bq. src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
bq. src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java 27842ed
bq. src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java 5a5c3c6
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 0b8ff30
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java a772360
bq. src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java a4cd9a3
bq. src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java 5b8b464
bq. src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 5802686
bq.
bq. Diff: https://reviews.apache.org/r/2119/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117899#comment-13117899 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/#review2208
-----------------------------------------------------------
+1
- ramkrishna
On 2011-09-29 23:26:34, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2119/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 23:26:34)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Replace deprecated HBaseClusterTestCase and subclasses.
bq.
bq.
bq. This addresses bug hbase-4503.
bq. https://issues.apache.org/jira/browse/hbase-4503
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
bq. src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
bq. src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
bq. src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
bq. src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java d7baba4
bq. src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
bq. src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java 27842ed
bq. src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java 5a5c3c6
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 0b8ff30
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java a772360
bq. src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java a4cd9a3
bq. src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java 5b8b464
bq. src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 5802686
bq.
bq. Diff: https://reviews.apache.org/r/2119/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4503) Purge deprecated
HBaseClusterTestCase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117673#comment-13117673 ]
jiraposter@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/#review2184
-----------------------------------------------------------
A couple of slight cleanup things, but overall +1.
src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
<https://reviews.apache.org/r/2119/#comment5084>
Does this file really need to be here? Yeah, its a little whitespace cleanup, but I don't think its *that* necessary
src/test/java/org/apache/hadoop/hbase/TestInfoServers.java
<https://reviews.apache.org/r/2119/#comment5086>
why not just assertEquals(${desc}, expected, content) here?
src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
<https://reviews.apache.org/r/2119/#comment5088>
Couldn't this just go into @BeforeClass?
src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
<https://reviews.apache.org/r/2119/#comment5090>
nitpick: just use iterable properties here?
Also, maybe abstract this into a single checking method? Not gaining a whole lot, but saves you some code copy.
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
<https://reviews.apache.org/r/2119/#comment5093>
nitpick: why drop the import?
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java
<https://reviews.apache.org/r/2119/#comment5094>
nitpick: (Again) import Assert.*?
src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java
<https://reviews.apache.org/r/2119/#comment5095>
This doesn't seem to fail into the same review need as the rest of the patch. I'm ok with the changes, but it would be better if they were for the same reason.
+/-0
- Jesse
On 2011-09-29 22:01:14, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2119/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 22:01:14)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Replace deprecated HBaseClusterTestCase and subclasses.
bq.
bq.
bq. This addresses bug hbase-4503.
bq. https://issues.apache.org/jira/browse/hbase-4503
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
bq. src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
bq. src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java 555174a
bq. src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
bq. src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
bq. src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java d7baba4
bq. src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
bq. src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java 27842ed
bq. src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java 5a5c3c6
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 0b8ff30
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java a772360
bq. src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java a4cd9a3
bq. src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java 5b8b464
bq. src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 5802686
bq.
bq. Diff: https://reviews.apache.org/r/2119/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira