You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/04/07 16:33:45 UTC

[GitHub] [beam] Abacn opened a new pull request, #26174: Bump tenacity version for pull_license script support Py3.11

Abacn opened a new pull request, #26174:
URL: https://github.com/apache/beam/pull/26174

   Fixes #26173
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500485934

   Run XVR_Flink PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26174:
URL: https://github.com/apache/beam/pull/26174#discussion_r1160868396


##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -19,10 +19,10 @@
 import CommonJobProperties as commonJobProperties
 import PostcommitJobBuilder
 
-import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
+import static PythonTestProperties.ESSENTIAL_VERSIONS

Review Comment:
   changed back to ALL_SUPPORTED_VERSIONS. Seed job passed: https://ci-beam.apache.org/job/beam_SeedJob/11388/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500475788

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500597222

   Run XVR_Flink PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500667185

   ':sdks:java:container:pullLicenses' now succeeded but Flink VR has many failing test, rerun to see if relevant
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500674573

   I see, there was a successful run earlier: https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink_PR/277/console merging for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500667248

   Run XVR_Flink PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on a diff in pull request #26174: Fix a couple of Python3.11 support followup

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26174:
URL: https://github.com/apache/beam/pull/26174#discussion_r1160853592


##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -19,10 +19,10 @@
 import CommonJobProperties as commonJobProperties
 import PostcommitJobBuilder
 
-import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
+import static PythonTestProperties.ESSENTIAL_VERSIONS

Review Comment:
   This calls out for an issue tracker that could monitor and file github issues for these long unhealthy tests. 
   
   Anyways, I am in support of keeping ALL_SUPPORTED_VERSIONS since we use this list to get lowest and highest python versions. Essential sounds like `good to have`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on a diff in pull request #26174: Fix a couple of Python3.11 support followup

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26174:
URL: https://github.com/apache/beam/pull/26174#discussion_r1160850963


##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -19,10 +19,10 @@
 import CommonJobProperties as commonJobProperties
 import PostcommitJobBuilder
 
-import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
+import static PythonTestProperties.ESSENTIAL_VERSIONS

Review Comment:
   All_SUPPORTED_VERSIONS sounds right in this context. Why change that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26174:
URL: https://github.com/apache/beam/pull/26174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26174:
URL: https://github.com/apache/beam/pull/26174#discussion_r1160852108


##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -19,10 +19,10 @@
 import CommonJobProperties as commonJobProperties
 import PostcommitJobBuilder
 
-import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
+import static PythonTestProperties.ESSENTIAL_VERSIONS

Review Comment:
   https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Sickbay_Python310/ never worked and no one find it for months. That led to me think about using ESSENTIAL_VERSIONS suffices.
   
   ```
   08:45:45 Task 'python310SickbayPostCommit' not found in root project 'beam'. Some candidates are: 'python37SickbayPostCommit', 'python38SickbayPostCommit', 'python39SickbayPostCommit'.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500474538

   Run XVR_Flink PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26174: Fix a couple of Python3.11 support followup

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26174:
URL: https://github.com/apache/beam/pull/26174#issuecomment-1500475035

   R: @AnandInguva 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org