You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "761417898 (via GitHub)" <gi...@apache.org> on 2025/08/07 07:42:19 UTC
[PR] fix: Failed to remove unwritable directories when creating tsfile [iotdb]
761417898 opened a new pull request, #16122:
URL: https://github.com/apache/iotdb/pull/16122
The issue occurs because mkdirs() fails silently - it returns false rather than throwing an IOException when unable to create directories.
```
try {
return folderManager.getNextWithRetry(
baseDir -> {
String tsFileDir =
baseDir
+ File.separator
+ logicalStorageGroup
+ File.separator
+ virtualStorageGroup
+ File.separator
+ timePartitionId;
fsFactory.getFile(tsFileDir).mkdirs();
return tsFileDir
+ File.separator
+ generateNewTsFileName(
time,
version,
innerSpaceCompactionCount,
crossSpaceCompactionCount,
customSuffix);
});
} catch (DiskSpaceInsufficientException e) {
LOGGER.error("All disks are full, cannot create tsfile directory", e);
throw new IOException("Disk space insufficient", e);
} catch (Exception e) {
LOGGER.warn("Failed to create tsfile directory after retries", e);
throw new IOException("Failed to create directory after retries", e);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Failed to remove unwritable directories when creating tsfile [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #16122:
URL: https://github.com/apache/iotdb/pull/16122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org