[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #2407: fix: solution of issue2268 draft

[GitBox <gi...@apache.org>]

abeizn commented on code in PR #2407:
URL: https://github.com/apache/incubator-devlake/pull/2407#discussion_r913443854


##########
plugins/github/tasks/commit_convertor.go:
##########
@@ -79,14 +78,14 @@ func ConvertCommits(taskCtx core.SubTaskContext) error {
 				Message:        githubCommit.Message,
 				Additions:      githubCommit.Additions,
 				Deletions:      githubCommit.Deletions,
-				AuthorId:       userDidGen.Generate(data.Options.ConnectionId, githubCommit.AuthorId),
+				AuthorId:       githubCommit.AuthorEmail,
 				AuthorName:     githubCommit.AuthorName,
 				AuthorEmail:    githubCommit.AuthorEmail,
 				AuthoredDate:   githubCommit.AuthoredDate,
 				CommitterName:  githubCommit.CommitterName,
 				CommitterEmail: githubCommit.CommitterEmail,
 				CommittedDate:  githubCommit.CommittedDate,
-				CommitterId:    userDidGen.Generate(data.Options.ConnectionId, githubCommit.CommitterId),
+				CommitterId:    githubCommit.CommitterEmail,

Review Comment:
   CommitterId and AuthorId use email?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org