[GitHub] [calcite] hsyuan removed a comment on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions

[GitBox <gi...@apache.org>]

hsyuan removed a comment on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#issuecomment-487456325
 
 
   Our common agreement is Rename EnumerableThetaJoin to NestedLoopJoin, and keep EnumerableCorrelate unchanged. If you do it in another patch, better revert the change for EnumerableCorrelate.
   
   
   
   
   
   Thanks~
   Haisheng Yuan------------------------------------------------------------------
   发件人：Danny Chan<no...@github.com>
   日　期：2019年04月29日 13:34:07
   收件人：apache/calcite<ca...@noreply.github.com>
   抄　送：Haisheng Yuan<h....@alibaba-inc.com>; Mention<me...@noreply.github.com>
   主　题：Re: [apache/calcite] [CALCITE-2969] Improve design of join-like relational expressions (#1157)
   
   @danny0405 commented on this pull request. 
   In core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableThetaJoin.java:
   > @@ -45,6 +46,7 @@
    /** Implementation of {@link org.apache.calcite.rel.core.Join} in
     * {@link org.apache.calcite.adapter.enumerable.EnumerableConvention enumerable calling convention}
     * that allows conditions that are not just {@code =} (equals). */
   +@Deprecated // to be removed before 2.0
   
   @hsyuan i hope to do it in another patch, cause this patch already modified too much files, split it to another patch looks more clear, :), i can do it also in this patch if it take no more burden for reviewing.
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or mute the thread.  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services