You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Damans227 (via GitHub)" <gi...@apache.org> on 2026/10/01 17:35:58 UTC
Re: [PR] Refactor: Modularize ApiResponseHelper#createUsageResponse [cloudstack]
Damans227 commented on code in PR #13490:
URL: https://github.com/apache/cloudstack/pull/13490#discussion_r4158491773
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -5312,18 +5439,18 @@ public NetworkPermissionsResponse createNetworkPermissionsResponse(NetworkPermis
return response;
}
- protected void handleCertificateResponse(String certStr, DirectDownloadCertificateResponse response) {
+protected void handleCertificateResponse(String certStr, DirectDownloadCertificateResponse response) {
Review Comment:
ok thats fixed, thanks
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -5312,18 +5439,18 @@ public NetworkPermissionsResponse createNetworkPermissionsResponse(NetworkPermis
return response;
}
- protected void handleCertificateResponse(String certStr, DirectDownloadCertificateResponse response) {
+protected void handleCertificateResponse(String certStr, DirectDownloadCertificateResponse response) {
try {
- Certificate cert = CertificateHelper.buildCertificate(certStr);
- if (cert instanceof X509CertImpl) {
- X509CertImpl certificate = (X509CertImpl) cert;
+ java.security.cert.Certificate cert = CertificateHelper.buildCertificate(certStr);
Review Comment:
ok that covers it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org