You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sslavic <gi...@git.apache.org> on 2014/05/12 17:11:27 UTC
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
GitHub user sslavic opened a pull request:
https://github.com/apache/spark/pull/739
SPARK-1803 Replaced colon in filenames with a dash
This patch replaces colon in several filenames with dash to make these filenames Windows compatible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sslavic/spark SPARK-1803
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #739
----
commit 9e1467dd04dda4bf7886c33870232fdbb0bf70bd
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:25:50Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 2fc785454fb8e45095bcae47aecda7905969573b
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:27:14Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 84f5d2fd168829474a28e0b3a4edb75067df1c25
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:28:17Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit ece0507fa498a232f24ad1ce903536a976cf271b
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:29:27Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 028e48af7ff105150a3f375c0076677efe78a7ac
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:30:20Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit b58512617957a9a06aa1fb288815aa82e1ce40d2
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:32:23Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit d6a3e2cf957582be7615f9db8ebd661fadcc9c78
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:34:37Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 004f8bb0496eb65c57098ade96e685995e8cd660
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:36:14Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 4774580ab7ac8d609b6505fb27afab2c3d20e1d1
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:40:25Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 40a962103a946b9135b5645e25c486fe43287bb2
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:41:38Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 401d99eb733d889e3adb5a9874b52b163d7a17ce
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:42:27Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit a49801fc820b6e58b2ce49cdff211c1fd16648a5
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:45:46Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit c5b5083e1f6b8fc9c9cb586e0ee44c997e4c03e8
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:51:56Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 8f5bf7fdb3743ea02093c64bb966f7d3c2d4a8fe
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:54:19Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 1c5dfff57129aaf0566d15016712798328d9e069
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T14:58:37Z
Replaced colon in file name with dash
This patch replaces colon in file name with dash to make file name Windows compatible.
commit 2b12776b5b2381f2da695c3e3fa272c2a8a89a2a
Author: Stevo Slavić <ss...@gmail.com>
Date: 2014-05-12T15:01:25Z
Fixed a typo in file name
This patch fixes a typo in file name - 'Partiton' is replaced with 'Partition'.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by sslavic <gi...@git.apache.org>.
Github user sslavic commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43154303
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43038376
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43156059
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43160188
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15000/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43038377
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14958/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43035167
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-42908837
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43035162
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-42844478
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43278462
Thanks. I've merged this into master & branch-1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-42908902
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by sslavic <gi...@git.apache.org>.
Github user sslavic commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43197402
Nice, tests passed. Please consider merging, maybe even for 1.0 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-42908906
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43035155
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43155783
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-42913115
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-42913118
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14925/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43156069
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1803 Replaced colon in filenames with a ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/739#issuecomment-43160187
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---