You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (JIRA)" <ji...@apache.org> on 2012/05/09 21:55:50 UTC
[jira] [Created] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Ryan Baxter created SHINDIG-1772:
------------------------------------
Summary: gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Key: SHINDIG-1772
URL: https://issues.apache.org/jira/browse/SHINDIG-1772
Project: Shindig
Issue Type: Bug
Affects Versions: 2.5.0
Reporter: Ryan Baxter
Assignee: Ryan Baxter
The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274582#comment-13274582 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/
-----------------------------------------------------------
(Updated 2012-05-14 12:39:40.305248)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Summary
-------
The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
This addresses bug shindig-1772.
https://issues.apache.org/jira/browse/shindig-1772
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
Diff: https://reviews.apache.org/r/5085/diff
Testing
-------
Update iotest.js
Thanks,
Erik
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273290#comment-13273290 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. > I am wondering if we want to try to not break backwards compatibility with this change. If there are gadgets out there that are passing VIEWER_SIGNED or OWNER_SIGNED as params they will stop working. While I think the chance of this is small, the code to support it is trivial. Comments in the code indicating why we look for both parameters would help too.
bq.
bq. Stanton Sievers wrote:
bq. +1
bq.
bq. Erik Bi wrote:
bq. Yes, it's easy to support both, but I thought that the chance somebody was using it should be very small, and if somebody did, he must have been looking through the code and found the parameter name, because it doesn't exist in the spec, and that is wrong...
bq. Do you think maybe it's better I ask around the shindig group see if someone used the old value before? if there is, we will add the support for old value but comment it deprecated, if not, just drop them.
I cant argue with anything you are saying, but I figured since it would take very little effort to add backward compatibility it wouldn't be a big deal. However the chance of people running into this is probably small so I don't see that strongly about it.
Please add the Shindig group as a reviewer.
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js, line 449
bq. > <https://reviews.apache.org/r/5085/diff/2/?file=108271#file108271line449>
bq. >
bq. > I prefer we use the new constant here
bq.
bq. Erik Bi wrote:
bq. the reason I still see the parameter name instead the constant is because I want to to keep constant with other code in the makeRequest function, as you can see, in this function, it checks many parameters, but all use the string value directly instead of the constant. your opinion?
Just because the rest of the code does it doesn't mean its the best thing to do. At least by using the constants you are "testing" them and making sure their values are what you expect.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7765
-----------------------------------------------------------
On 2012-05-10 03:44:35, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 03:44:35)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272518#comment-13272518 ]
Ryan Baxter commented on SHINDIG-1772:
--------------------------------------
Rich I think I am a little confused on what you are saying here, when you say client are you talking about the gadget or the container?
With the current patch, if my gadget used the old shindig defined constants then my gadget's functionality could break. For example setting the old parameters to false will cause Shindig not to add any extra URL parameters when making the request for a request token. If the provider you are doing the dance with is very strict and there are extra parameters on the request it may reject the request all together. When I go to use my gadget in a 2.5 container all of a sudden it will stop working. It won't take much to support both so we can avoid situations like this.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276710#comment-13276710 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
bq. On 2012-05-14 13:16:37, Ryan Baxter wrote:
bq. > Erik every looks good, please attach the patch to the JIRA and I will commit this.
Committed revision 1339144. Please close the review.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7840
-----------------------------------------------------------
On 2012-05-14 12:39:40, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-14 12:39:40)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Fix For: 2.5.0
>
> Attachments: 1772.patch
>
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1772:
---------------------------------
Fix Version/s: (was: 2.5.0)
2.5.0-beta2
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Fix For: 2.5.0-beta2
>
> Attachments: 1772.patch
>
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter resolved SHINDIG-1772.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.5.0
Assignee: (was: Ryan Baxter)
Committed revision 1339144
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Fix For: 2.5.0
>
> Attachments: 1772.patch
>
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274581#comment-13274581 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js, line 449
bq. > <https://reviews.apache.org/r/5085/diff/2/?file=108271#file108271line449>
bq. >
bq. > I prefer we use the new constant here
bq.
bq. Erik Bi wrote:
bq. the reason I still see the parameter name instead the constant is because I want to to keep constant with other code in the makeRequest function, as you can see, in this function, it checks many parameters, but all use the string value directly instead of the constant. your opinion?
bq.
bq. Ryan Baxter wrote:
bq. Just because the rest of the code does it doesn't mean its the best thing to do. At least by using the constants you are "testing" them and making sure their values are what you expect.
Make sense. I will change it to using constant.
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7765
-----------------------------------------------------------
On 2012-05-14 12:39:40, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-14 12:39:40)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272259#comment-13272259 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7763
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-05-10 03:44:35, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 03:44:35)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272280#comment-13272280 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7765
-----------------------------------------------------------
I am wondering if we want to try to not break backwards compatibility with this change. If there are gadgets out there that are passing VIEWER_SIGNED or OWNER_SIGNED as params they will stop working. While I think the chance of this is small, the code to support it is trivial. Comments in the code indicating why we look for both parameters would help too.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17072>
I prefer we use the new constant here
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17073>
I prefer we use the new constant here
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17074>
I prefer we use the new constant here
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17075>
I prefer we use the new constant here
- Ryan
On 2012-05-10 03:44:35, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 03:44:35)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "Erik BI (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276414#comment-13276414 ]
Erik BI commented on SHINDIG-1772:
----------------------------------
Ryan. I met server error when I tried to attached the patch file. here it is.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Attachments: 1772.patch
>
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272364#comment-13272364 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. > I am wondering if we want to try to not break backwards compatibility with this change. If there are gadgets out there that are passing VIEWER_SIGNED or OWNER_SIGNED as params they will stop working. While I think the chance of this is small, the code to support it is trivial. Comments in the code indicating why we look for both parameters would help too.
+1
- Stanton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7765
-----------------------------------------------------------
On 2012-05-10 03:44:35, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 03:44:35)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272062#comment-13272062 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/
-----------------------------------------------------------
Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
Summary
-------
The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
This addresses bug shindig-1772.
https://issues.apache.org/jira/browse/shindig-1772
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
Diff: https://reviews.apache.org/r/5085/diff
Testing
-------
Update iotest.js
Thanks,
Erik
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272958#comment-13272958 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. > I am wondering if we want to try to not break backwards compatibility with this change. If there are gadgets out there that are passing VIEWER_SIGNED or OWNER_SIGNED as params they will stop working. While I think the chance of this is small, the code to support it is trivial. Comments in the code indicating why we look for both parameters would help too.
bq.
bq. Stanton Sievers wrote:
bq. +1
Yes, it's easy to support both, but I thought that the chance somebody was using it should be very small, and if somebody did, he must have been looking through the code and found the parameter name, because it doesn't exist in the spec, and that is wrong...
Do you think maybe it's better I ask around the shindig group see if someone used the old value before? if there is, we will add the support for old value but comment it deprecated, if not, just drop them.
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js, line 449
bq. > <https://reviews.apache.org/r/5085/diff/2/?file=108271#file108271line449>
bq. >
bq. > I prefer we use the new constant here
the reason I still see the parameter name instead the constant is because I want to to keep constant with other code in the makeRequest function, as you can see, in this function, it checks many parameters, but all use the string value directly instead of the constant. your opinion?
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7765
-----------------------------------------------------------
On 2012-05-10 03:44:35, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 03:44:35)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274586#comment-13274586 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7840
-----------------------------------------------------------
Ship it!
Erik every looks good, please attach the patch to the JIRA and I will commit this.
- Ryan
On 2012-05-14 12:39:40, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-14 12:39:40)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "Erik BI (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik BI updated SHINDIG-1772:
-----------------------------
Attachment: 1772.patch
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Attachments: 1772.patch
>
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Posted by "Rich Thompson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272400#comment-13272400 ]
Rich Thompson commented on SHINDIG-1772:
----------------------------------------
If the server supports both the spec defined constant and the old Shindig defined constant then the client should support both for backwards compatibility reasons. If the client was just using the wrong value for these use cases and the server ignored those values, then the old values were broken and should just be dropped
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira