You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (JIRA)" <ji...@apache.org> on 2012/10/05 03:29:47 UTC
[jira] [Created] (HBASE-6955) Block read time should be in ms, not
in ns
Mikhail Bautin created HBASE-6955:
-------------------------------------
Summary: Block read time should be in ms, not in ns
Key: HBASE-6955
URL: https://issues.apache.org/jira/browse/HBASE-6955
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Priority: Minor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms,
not in ns
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469979#comment-13469979 ]
Phabricator commented on HBASE-6955:
------------------------------------
Kannan has commented on the revision "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java:312 In RegionServerMetrics.java, can we also export the "pread" metrics much like we do for the non-pread case:
int ops = HFile.getReadOps();
if (ops != 0) this.fsReadLatency.inc(ops, HFile.getReadTimeMs());
REVISION DETAIL
https://reviews.facebook.net/D5901
To: Kannan, JIRA, mbautin
> Block read time should be in ms, not in ns
> ------------------------------------------
>
> Key: HBASE-6955
> URL: https://issues.apache.org/jira/browse/HBASE-6955
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5901.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms,
not in ns
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475598#comment-13475598 ]
Phabricator commented on HBASE-6955:
------------------------------------
mbautin has closed the revision "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns".
CHANGED PRIOR TO COMMIT
https://reviews.facebook.net/D5901?vs=19917&id=19947#differential-review-toc
REVISION DETAIL
https://reviews.facebook.net/D5901
COMMIT
https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1397821
To: Kannan, JIRA, mbautin
> Block read time should be in ms, not in ns
> ------------------------------------------
>
> Key: HBASE-6955
> URL: https://issues.apache.org/jira/browse/HBASE-6955
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5901.1.patch, D5901.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6955) Block read time should be in ms, not
in ns
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-6955:
-------------------------------
Attachment: D5901.2.patch
mbautin updated the revision "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns".
Reviewers: Kannan, JIRA
Addressing Kannan's comments.
REVISION DETAIL
https://reviews.facebook.net/D5901
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
src/test/java/org/apache/hadoop/hbase/regionserver/HFileReadWriteTest.java
To: Kannan, JIRA, mbautin
> Block read time should be in ms, not in ns
> ------------------------------------------
>
> Key: HBASE-6955
> URL: https://issues.apache.org/jira/browse/HBASE-6955
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5901.1.patch, D5901.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms,
not in ns
Posted by "liang xie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482083#comment-13482083 ]
liang xie commented on HBASE-6955:
----------------------------------
do we need to port this to trunk as well ? Revision: 1397821 in fb-89 branch has done this job
> Block read time should be in ms, not in ns
> ------------------------------------------
>
> Key: HBASE-6955
> URL: https://issues.apache.org/jira/browse/HBASE-6955
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5901.1.patch, D5901.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms,
not in ns
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475319#comment-13475319 ]
Phabricator commented on HBASE-6955:
------------------------------------
Kannan has accepted the revision "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns".
lgtm!
REVISION DETAIL
https://reviews.facebook.net/D5901
BRANCH
fix_fs_read_time_v5
To: Kannan, JIRA, mbautin
> Block read time should be in ms, not in ns
> ------------------------------------------
>
> Key: HBASE-6955
> URL: https://issues.apache.org/jira/browse/HBASE-6955
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5901.1.patch, D5901.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms,
not in ns
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482786#comment-13482786 ]
Mikhail Bautin commented on HBASE-6955:
---------------------------------------
[~xieliang007]: yes, it would be great to port this to trunk.
> Block read time should be in ms, not in ns
> ------------------------------------------
>
> Key: HBASE-6955
> URL: https://issues.apache.org/jira/browse/HBASE-6955
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5901.1.patch, D5901.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6955) Block read time should be in ms, not
in ns
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-6955:
-------------------------------
Attachment: D5901.1.patch
mbautin requested code review of "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns".
Reviewers: Kannan, JIRA
We update block read time in nanoseconds, which is inconsistent with all other latency metrics in the system.
TEST PLAN
Unit tests
REVISION DETAIL
https://reviews.facebook.net/D5901
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/13995/
To: Kannan, JIRA, mbautin
> Block read time should be in ms, not in ns
> ------------------------------------------
>
> Key: HBASE-6955
> URL: https://issues.apache.org/jira/browse/HBASE-6955
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D5901.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira