[GitHub] [tinkerpop] jorgebay commented on pull request #1547: Add GraphBinary serialization support to gremlin-javascript

[GitBox <gi...@apache.org>]

jorgebay commented on PR #1547:
URL: https://github.com/apache/tinkerpop/pull/1547#issuecomment-1135522965

   I think we should would avoid using env variables for `Connection` properties default directly.
   
   In order to facilitate testing, we could use the same env variable but use it to create the `Client` / `Connection` instance in the test modules. For example, in the `test/helper.js` module (pseudocode):
   
   ```javascript
   exports.getClient = function getClient(traversalSource) {
     return new Client(serverUrl, { traversalSource, mimeType: process.env.YOUR_TEST_VAR });
   };
   ```
   
   That way modules within the `lib` don't have to be aware about test env vars.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org