You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/23 08:18:36 UTC
[GitHub] [flink] zentol commented on a change in pull request #16935: [FLINK-23172][docs] Fix broken links to Task Failure Recovery page on Configuration page
zentol commented on a change in pull request #16935:
URL: https://github.com/apache/flink/pull/16935#discussion_r693759349
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java
##########
@@ -63,21 +63,21 @@
code("fixeddelay"),
code("fixed-delay"),
link(
- "{{.Site.BaseURL}}docs/ops/state/task_failure_recovery#fixed-delay-restart-strategy",
+ "{{.Site.BaseURL}}/{{.Site.LanguagePrefix}}/docs/ops/state/task_failure_recovery#fixed-delay-restart-strategy",
Review comment:
No other link seems to be using the LanguagePrefix, why should this one? Can we not use `{{< ref "docs/.." >}}` because the generated files are treated as short-codes?
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -280,7 +280,7 @@
"'region': Restarts all tasks that could be affected by the task failure. "
+ "More details can be found %s.",
link(
- "{{.Site.BaseURL}}docs/ops/state/task_failure_recovery/#restart-pipelined-region-failover-strategy",
+ "{{.Site.BaseURL}}/{{.Site.LanguagePrefix}}/docs/ops/state/task_failure_recovery/#restart-pipelined-region-failover-strategy",
Review comment:
```suggestion
"{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/ops/state/task_failure_recovery/#restart-pipelined-region-failover-strategy",
```
The LanguagePrefix already contains a leading slash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org