You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "847850277 (via GitHub)" <gi...@apache.org> on 2023/08/05 05:54:54 UTC
[PR] [ISSUE #4264]Some optimizations for ProducerService (eventmesh)
847850277 opened a new pull request, #4334:
URL: https://github.com/apache/eventmesh/pull/4334
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4264.
1、Make field non-public and provide accessors if needed.
2、Restore interrupted state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4264][Enhancement] Some optimizations for ProducerService (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #4334:
URL: https://github.com/apache/eventmesh/pull/4334#issuecomment-1666454066
@847850277 thanks for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4264][Enhancement] Some optimizations for ProducerService (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4334:
URL: https://github.com/apache/eventmesh/pull/4334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4264][Enhancement] Some optimizations for ProducerService (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4334:
URL: https://github.com/apache/eventmesh/pull/4334#issuecomment-1666407596
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4334](https://app.codecov.io/gh/apache/eventmesh/pull/4334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (70866ae) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/19dd2b1d5cc7abd327b808a3707ca4aaafce8b31?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (19dd2b1) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 70866ae differs from pull request most recent head 689e295. Consider uploading reports for the commit 689e295 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4334 +/- ##
============================================
- Coverage 16.35% 16.34% -0.01%
- Complexity 1362 1363 +1
============================================
Files 594 594
Lines 25393 25389 -4
Branches 2393 2379 -14
============================================
- Hits 4152 4151 -1
+ Misses 20818 20817 -1
+ Partials 423 421 -2
```
[see 8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4334/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org