You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by "Olivier Grisel (JIRA)" <ji...@apache.org> on 2011/02/11 16:45:57 UTC

[jira] Created: (STANBOL-78) Make the default eclipe code formatter not introduce trailing spaces

Make the default eclipe code formatter not introduce trailing spaces
--------------------------------------------------------------------

                 Key: STANBOL-78
                 URL: https://issues.apache.org/jira/browse/STANBOL-78
             Project: Stanbol
          Issue Type: Wish
            Reporter: Olivier Grisel
            Assignee: Olivier Grisel
            Priority: Trivial


I would like to change the recommended eclipse code formatter so that it stops introducing trailing spaces in java source code files. Trailing spaces make diff uselessly noisy with invisible characters.

The change is trivial:

Index: conventions/stanbol-eclipse-codeformatter.xml
===================================================================
--- conventions/stanbol-eclipse-codeformatter.xml	(revision 1069799)
+++ conventions/stanbol-eclipse-codeformatter.xml	(working copy)
@@ -144,7 +144,7 @@
 <setting id="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration" value="82"/>
 <setting id="org.eclipse.jdt.core.formatter.insert_space_after_assignment_operator" value="insert"/>
 <setting id="org.eclipse.jdt.core.formatter.insert_space_before_assignment_operator" value="insert"/>
-<setting id="org.eclipse.jdt.core.formatter.indent_empty_lines" value="true"/>
+<setting id="org.eclipse.jdt.core.formatter.indent_empty_lines" value="false"/>
 <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_synchronized" value="do not insert"/>
 <setting id="org.eclipse.jdt.core.formatter.insert_space_after_closing_paren_in_cast" value="insert"/>
 <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_declaration_parameters" value="insert"/>
(svn:r1069799) ~/coding/stanbol> svn diff > ~/Desktop/formatter-no-trailing-space.diff


I will check it in if nobody disagree.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (STANBOL-78) Make the default eclipe code formatter not introduce trailing spaces

Posted by "Fabian Christ (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/STANBOL-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993875#comment-12993875 ] 

Fabian Christ commented on STANBOL-78:
--------------------------------------

Sounds reasonable. I am +1 with this.

> Make the default eclipe code formatter not introduce trailing spaces
> --------------------------------------------------------------------
>
>                 Key: STANBOL-78
>                 URL: https://issues.apache.org/jira/browse/STANBOL-78
>             Project: Stanbol
>          Issue Type: Wish
>            Reporter: Olivier Grisel
>            Assignee: Olivier Grisel
>            Priority: Trivial
>
> I would like to change the recommended eclipse code formatter so that it stops introducing trailing spaces in java source code files. Trailing spaces make diff uselessly noisy with invisible characters.
> The change is trivial:
> Index: conventions/stanbol-eclipse-codeformatter.xml
> ===================================================================
> --- conventions/stanbol-eclipse-codeformatter.xml	(revision 1069799)
> +++ conventions/stanbol-eclipse-codeformatter.xml	(working copy)
> @@ -144,7 +144,7 @@
>  <setting id="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration" value="82"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_assignment_operator" value="insert"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_before_assignment_operator" value="insert"/>
> -<setting id="org.eclipse.jdt.core.formatter.indent_empty_lines" value="true"/>
> +<setting id="org.eclipse.jdt.core.formatter.indent_empty_lines" value="false"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_synchronized" value="do not insert"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_closing_paren_in_cast" value="insert"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_declaration_parameters" value="insert"/>
> (svn:r1069799) ~/coding/stanbol> svn diff > ~/Desktop/formatter-no-trailing-space.diff
> I will check it in if nobody disagree.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (STANBOL-78) Make the default eclipe code formatter not introduce trailing spaces

Posted by "Olivier Grisel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/STANBOL-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Grisel resolved STANBOL-78.
-----------------------------------

    Resolution: Fixed

This change has been check-in to trunk. Please update your eclipse formatter by going to:

  Preferences > Java > Code Style > Formatter > Import...

And then select the file and apply. You can then select a portion of source code by selecting it and pressing "Shift - Ctrl - F".

> Make the default eclipe code formatter not introduce trailing spaces
> --------------------------------------------------------------------
>
>                 Key: STANBOL-78
>                 URL: https://issues.apache.org/jira/browse/STANBOL-78
>             Project: Stanbol
>          Issue Type: Wish
>            Reporter: Olivier Grisel
>            Assignee: Olivier Grisel
>            Priority: Trivial
>
> I would like to change the recommended eclipse code formatter so that it stops introducing trailing spaces in java source code files. Trailing spaces make diff uselessly noisy with invisible characters.
> The change is trivial:
> Index: conventions/stanbol-eclipse-codeformatter.xml
> ===================================================================
> --- conventions/stanbol-eclipse-codeformatter.xml	(revision 1069799)
> +++ conventions/stanbol-eclipse-codeformatter.xml	(working copy)
> @@ -144,7 +144,7 @@
>  <setting id="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration" value="82"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_assignment_operator" value="insert"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_before_assignment_operator" value="insert"/>
> -<setting id="org.eclipse.jdt.core.formatter.indent_empty_lines" value="true"/>
> +<setting id="org.eclipse.jdt.core.formatter.indent_empty_lines" value="false"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_synchronized" value="do not insert"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_closing_paren_in_cast" value="insert"/>
>  <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_declaration_parameters" value="insert"/>
> (svn:r1069799) ~/coding/stanbol> svn diff > ~/Desktop/formatter-no-trailing-space.diff
> I will check it in if nobody disagree.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira