[GitHub] [iceberg] kbendick commented on a change in pull request #3823: Docs: Flink create table with primary key.(#3822)

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3823:
URL: https://github.com/apache/iceberg/pull/3823#discussion_r777781323



##########
File path: site/docs/flink.md
##########
@@ -301,7 +301,22 @@ Table create commands support the most commonly used [flink create clauses](http
 * `COMMENT 'table document'` to set a table description.
 * `WITH ('key'='value', ...)` to set [table configuration](./configuration.md) which will be stored in apache iceberg table properties.
 
-Currently, it does not support computed column, primary key and watermark definition etc.
+Currently, it does not support computed column and watermark definition etc.
+
+### `PRIMARY KEY`
+
+To declare primary key(s) in a table, use `PRIMARY KEY ... NOT ENFORCED`:
+
+```sql
+CREATE TABLE `hive_catalog`.`default`.`sample` (
+    id BIGINT COMMENT 'unique id',
+    data STRING,
+    PRIMARY KEY (id) NOT ENFORCED

Review comment:
       I don't personally think it's worth another example. My understanding is that this is more of the differences in available FlinkSQL syntax, correct?
   
   If so, I don't think we need to demonstrate all possible forms for the same thing. It would be better left to their documentation to show various forms. Too many examples can make the document hard to read as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org