You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "ccxxxyy (via GitHub)" <gi...@apache.org> on 2026/03/15 04:55:46 UTC
[PR] Support parsing Doris BROKER LOAD syntax [shardingsphere]
ccxxxyy opened a new pull request, #38441:
URL: https://github.com/apache/shardingsphere/pull/38441
for https://github.com/apache/shardingsphere/issues/31459
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Doris BROKER LOAD syntax [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38441:
URL: https://github.com/apache/shardingsphere/pull/38441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Doris BROKER LOAD syntax [shardingsphere]
Posted by "ccxxxyy (via GitHub)" <gi...@apache.org>.
ccxxxyy commented on PR #38441:
URL: https://github.com/apache/shardingsphere/pull/38441#issuecomment-4062432669
@terrymanu Hi! Thank you for your guidance. I have made the revisions as requested and would greatly appreciate it if you could review them when you have time. Below is a summary of the changes in this latest commit https://github.com/apache/shardingsphere/pull/38441/changes/54d153892938ab57b1619a5039e61a96bc1b2322:
- Line 387: Changed BROKER string_? to `BROKER string_` (removed the ? quantifier).
- Line 395: Changed EQ_? to `EQ_ `(removed the ? quantifier).
- Adjusted the corresponding logic in the `visitor`
All assertions have passed.
Please review the changes at your convenience. Thank you for your corrections and feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Doris BROKER LOAD syntax [shardingsphere]
Posted by "ccxxxyy (via GitHub)" <gi...@apache.org>.
ccxxxyy commented on PR #38441:
URL: https://github.com/apache/shardingsphere/pull/38441#issuecomment-4062240632
Regarding **APPEND**, Doris treats it as reserved keywords
Regarding **BROKER**, **COMPRESS_TYPE**, **LABEL** and **NEGATIVE**, [Doris ](https://doris.apache.org/docs/4.x/sql-manual/basic-element/reserved-keywords)does not treat them as reserved keywords. Therefore, I have added them to `identifierKeywordsUnambiguous` in `BaseRule.g4`, so that they can be used in places where identifiers are expected.
My reasoning is as follows:
The identifier usage chain is:
tableName → name → identifier
columnName → identifier
and identifier includes identifierKeywordsUnambiguous.
This means that these keywords can be used as identifiers, such as table names, column names, and database names, without requiring quotation marks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Doris BROKER LOAD syntax [shardingsphere]
Posted by "ccxxxyy (via GitHub)" <gi...@apache.org>.
ccxxxyy commented on PR #38441:
URL: https://github.com/apache/shardingsphere/pull/38441#issuecomment-4062434506
<img width="600" height="613" alt="image" src="https://github.com/user-attachments/assets/d024dfcd-338b-44b1-9d58-4f5f5bd15ce9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org