You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/27 09:27:16 UTC

[GitHub] [skywalking-kubernetes-event-exporter] kezhenxu94 opened a new pull request #10: Remove filter for event reason, only filter by whether service name is empty or not

kezhenxu94 opened a new pull request #10:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/10


   As exporter is able to identify the event's service, we can simply let go all events and only filter by whether or not the service name is empty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kubernetes-event-exporter] wu-sheng commented on a change in pull request #10: Remove filter for event reason, only filter by whether service name is empty or not

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #10:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/10#discussion_r640454986



##########
File path: examples/debug.yaml
##########
@@ -17,15 +17,15 @@
 #
 
 filters:
-  - reason: "Started|Killing"     # filter events of the specified reason, regular expression like "Killing|Killed" is supported.
+  - reason: ""     # filter events of the specified reason, regular expression like "Killing|Killed" is supported.
     message: ""    # filter events of the specified message, regular expression like "Pulling container.*" is supported.
     minCount: 1    # filter events whose count is >= the specified value.
     type: ""       # filter events of the specified type, regular expression like "Normal|Error" is supported.
     action: ""     # filter events of the specified action, regular expression is supported.
-    kind: "Pod|Service"       # filter events of the specified kind, regular expression like "Pod|Service" is supported.
+    kind: ""       # filter events of the specified kind, regular expression like "Pod|Service" is supported.
     namespace: "default"  # filter events from the specified namespace, regular expression like "default|bookinfo" is supported, empty means all namespaces.
     name: ""       # filter events of the specified involved object name, regular expression like ".*bookinfo.*" is supported.
-    service: "[^\\s]{1,}"  # filter events belonging to services whose name is not empty.
+    service: ""  # filter events belonging to services whose name is not empty.

Review comment:
       > only filter by whether service name is empty or not
   
   I am confused with the title with this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kubernetes-event-exporter] kezhenxu94 merged pull request #10: Remove filter for event reason, only filter by whether service name is empty or not

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #10:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/10


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kubernetes-event-exporter] kezhenxu94 commented on a change in pull request #10: Remove filter for event reason, only filter by whether service name is empty or not

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #10:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/10#discussion_r640458248



##########
File path: examples/debug.yaml
##########
@@ -17,15 +17,15 @@
 #
 
 filters:
-  - reason: "Started|Killing"     # filter events of the specified reason, regular expression like "Killing|Killed" is supported.
+  - reason: ""     # filter events of the specified reason, regular expression like "Killing|Killed" is supported.
     message: ""    # filter events of the specified message, regular expression like "Pulling container.*" is supported.
     minCount: 1    # filter events whose count is >= the specified value.
     type: ""       # filter events of the specified type, regular expression like "Normal|Error" is supported.
     action: ""     # filter events of the specified action, regular expression is supported.
-    kind: "Pod|Service"       # filter events of the specified kind, regular expression like "Pod|Service" is supported.
+    kind: ""       # filter events of the specified kind, regular expression like "Pod|Service" is supported.
     namespace: "default"  # filter events from the specified namespace, regular expression like "default|bookinfo" is supported, empty means all namespaces.
     name: ""       # filter events of the specified involved object name, regular expression like ".*bookinfo.*" is supported.
-    service: "[^\\s]{1,}"  # filter events belonging to services whose name is not empty.
+    service: ""  # filter events belonging to services whose name is not empty.

Review comment:
       > > only filter by whether service name is empty or not
   > 
   > I am confused with the title with this change.
   
   Never mind. This is for debugging, and it logs the events to console. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org