You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "swebb2066 (via GitHub)" <gi...@apache.org> on 2026/10/21 05:03:07 UTC
[PR] Ensure Log4cxx usage does not generate compiler warnings [logging-log4cxx]
swebb2066 opened a new pull request, #788:
URL: https://github.com/apache/logging-log4cxx/pull/788
Fixes #787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure Log4cxx usage does not generate compiler warnings [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on PR #788:
URL: https://github.com/apache/logging-log4cxx/pull/788#issuecomment-6328776677
> should we also add a CI check that will build with warnings enabled and fail if there are any warnings?
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure Log4cxx usage does not generate compiler warnings [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on PR #788:
URL: https://github.com/apache/logging-log4cxx/pull/788#issuecomment-6315555309
should we also add a CI check that will build with warnings enabled and fail if there are any warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure Log4cxx usage does not generate compiler warnings [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on code in PR #788:
URL: https://github.com/apache/logging-log4cxx/pull/788#discussion_r4343176909
##########
src/examples/cpp/MyApp/CMakeLists.txt:
##########
@@ -17,6 +17,9 @@
cmake_minimum_required(VERSION 3.13)
project(MyApp LANGUAGES CXX)
+# Ensure Log4cxx does not throw any warnings when used
+set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
Review Comment:
It doesn't look like this will _enable_ specific warnings, I think we need to do that ourselves. Google AI claims that `/W4` for MSVC and `-Wall -Wextra` for GCC are equivalent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure Log4cxx usage does not generate compiler warnings [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 merged PR #788:
URL: https://github.com/apache/logging-log4cxx/pull/788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure Log4cxx usage does not generate compiler warnings [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on code in PR #788:
URL: https://github.com/apache/logging-log4cxx/pull/788#discussion_r4343407420
##########
src/examples/cpp/MyApp/CMakeLists.txt:
##########
@@ -17,6 +17,9 @@
cmake_minimum_required(VERSION 3.13)
project(MyApp LANGUAGES CXX)
+# Ensure Log4cxx does not throw any warnings when used
+set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
Review Comment:
I will have to add that to the next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org